From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752310AbbCKCPg (ORCPT ); Tue, 10 Mar 2015 22:15:36 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:36252 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbbCKCPf (ORCPT ); Tue, 10 Mar 2015 22:15:35 -0400 Message-ID: <54FFA4FB.80007@roeck-us.net> Date: Tue, 10 Mar 2015 19:14:19 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Randy Dunlap , LKML , lm-sensors@lm-sensors.org CC: Jean Delvare , Simon Guinot Subject: Re: [PATCH -next] hwmon: fix gpio-fan.c build References: <54FF8171.9080101@infradead.org> In-Reply-To: <54FF8171.9080101@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.54FFA546.0127,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 4 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2015 04:42 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build error when CONFIG_THERMAL=m and SENSORS_GPIO_FAN=y > by preventing that combination. > > Fixes these build errors: > > drivers/built-in.o: In function `gpio_fan_remove': > gpio-fan.c:(.text+0x21e97e): undefined reference to `thermal_cooling_device_unregister' > drivers/built-in.o: In function `gpio_fan_probe': > gpio-fan.c:(.text+0x21efbc): undefined reference to `thermal_cooling_device_register' > > Signed-off-by: Randy Dunlap > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: lm-sensors@lm-sensors.org > Cc: Simon Guinot > --- > drivers/hwmon/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20150310.orig/drivers/hwmon/Kconfig > +++ linux-next-20150310/drivers/hwmon/Kconfig > @@ -510,6 +510,7 @@ config SENSORS_G762 > config SENSORS_GPIO_FAN > tristate "GPIO fan" > depends on GPIOLIB > + depends on THERMAL || THERMAL=n > help > If you say yes here you get support for fans connected to GPIO lines. > > Applied, thanks. I really have to add that combination to my build tests :-( Guenter