From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751306AbbCKHcr (ORCPT ); Wed, 11 Mar 2015 03:32:47 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:33370 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbbCKHcp (ORCPT ); Wed, 11 Mar 2015 03:32:45 -0400 Message-ID: <54FFEF99.4030806@gmail.com> Date: Wed, 11 Mar 2015 08:32:41 +0100 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Joe Perches CC: gregkh@linuxfoundation.org, mdcasey@chabloom.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: rtllib_wx: code style improvements References: <1426027985-28827-1-git-send-email-mateusz.kulikowski@gmail.com> <1426028514.18060.64.camel@perches.com> In-Reply-To: <1426028514.18060.64.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.03.2015 00:01, Joe Perches wrote: > On Tue, 2015-03-10 at 23:53 +0100, Mateusz Kulikowski wrote: >> - Replaced printk() with netdev_*() > > trivia: > >> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c > [] >> @@ -423,11 +421,8 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee, >> NULL, (*crypt)->priv); >> if (len == 0) { >> /* Set a default key of all 0 */ >> - printk(KERN_INFO "Setting key %d to all zero.\n", >> - key); >> - >> - RTLLIB_DEBUG_WX("Setting key %d to all zero.\n", >> - key); >> + netdev_info(dev, "Setting key %d to all zero.\n", key); >> + RTLLIB_DEBUG_WX("Setting key %d to all zero.\n", key); > > This isn't something you've created but it > seems more than a bit nonsensical to emit the > same message at different logging levels. Thanks for hint - I'll throw away duplicate messages for v2. As for all standalone RTLLIB_DEBUG* entries (in whole driver) - I think it may be better to replace them with netdev_dbg, and use dynamic debug when needed. M.