From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B83A42C3248 for ; Fri, 17 Apr 2026 15:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776438958; cv=none; b=Tix9Jv6J2w65xHh6yuFqggt+qWMHDtsYWI6fm6XWRZ+U4OGpyjG7b1MZ/mK5PVblqKQ0m6TkvBWpRtC2oSuTIRHN/CzSSmGQfFSc5nOLv6PZAwhI1zRfzQgPfQrB/ygD5pEARJMdKJ2M4JOIrrnrCG4R2c81tk5vDJppjbk3Pvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776438958; c=relaxed/simple; bh=FUQ58Buz0KTXfDHUt9IvxtvQxDPIY63zZw+nNkTx/oM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pzK0tT7OFOe+8TGUI60uc+jZqfLWa+iRJAFYDR3dLqQyEIG5E9/83EHZRtIRK0qIsqgY4MfZ6PB+Do2QXEvZN4+rBF7xF+YtISCBt7G7nfMY6qWmK2y/TV8IacWYiM8OZiLvxzBn0wGXxXFxH0cS63G9AJ+ITiN+8st1QUhabZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oI/gUHIP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=it9rLXW0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oI/gUHIP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="it9rLXW0" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H8npcB3100156 for ; Fri, 17 Apr 2026 15:15:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PKD760IDJ43/TbT9ovAN8NccWsYNnr9nvVlw/x2cbHU=; b=oI/gUHIPaLvOHB0W wJSq7dp8aYAuJF6x+jcuxWvSl1apaj8ddzZq1Yw82kVWkqLTJX8VoyGQcy/PfENc 6DI/QcSgpjLpeTYfrljdQ9XIkCmzz9eNza1Gzl5yKySFsentjHoIDK3W54X/Y7qZ kGBg//o7n9rs6TZ5O4R4ILP4d5eD7KFL3iXkYAUbZ1wdF3FTJN9z6H1wPGROG+hv M54dqnLGGVXEnTuIQa+duTCPB5J0ovucwTVc/ykEirhQUtg5BrY8vXKnqKOfm4Jc X5ZegTgfXuTLj5LJvewYjV4RyKGNEV+XhuNR+8+sWYIsQVFPnbRT0454lyz3uoPZ dozuaA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkhpu1a4n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 15:15:55 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b242062308so14211315ad.2 for ; Fri, 17 Apr 2026 08:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776438954; x=1777043754; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PKD760IDJ43/TbT9ovAN8NccWsYNnr9nvVlw/x2cbHU=; b=it9rLXW0/I9Mo2/LIiyzMvBwzzRkleCtR6yidfCRSFwl2HeCkmAKy1eSlDMdD/uYSn 9iAMVWSfzlNstfFm6SgaG9QpA+kTPODNLuAEj0QxHDngvP2NU+e/Fy4da3WlKdxDAUKg p4qpnWS9v/qivjvOAew4mditU5S2SBYraUpeUIIjQLJ+pKjwTy4QStdQJpmyL9NY3L1C +EpBwCkD1d/1hosXSuGYKQzG/1WS+DiXOplKOYG0PnpOMsoaRkdwrltP87/X5ZC0DsPq byd/9NssH59F8WTBaxa+JSr6OANik42irEgtgXvbLuUdcHVwK7EVqjPJE3/am74WXNYX WZcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776438954; x=1777043754; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PKD760IDJ43/TbT9ovAN8NccWsYNnr9nvVlw/x2cbHU=; b=YujW3iBY9lZ/F+k1Ui6FflGzK2RLnKw7+1JI4bFzbX8dw8Kt8HUv5jKkg/3BbSoHiv EDr7yPVJBdYWQs/Esp42DwO47mrvbvlc7M2s6rgEZViPPC7E0V4y5XzL4S+gQzevax4p gPhKd8I6OQNSSRn62YwCP5VzkippTwtyn0l6s8O9QFH9PCxJHQ4HFG7I7Zbtw+gvncgy UorhOdqlmExlpJ8CcKLUrUPUPeO3KkK5oo2m9EMHvYnyufOoaMMoj705ZX39y4zD6gAP NwZ37zlscqs7QMcjCXHfHbQW+NKznhs84amnum+YSy7Mva3Xwdk1Qg9AlxXtoAg4wpiJ 012A== X-Forwarded-Encrypted: i=1; AFNElJ9nlbKq6mWqDjEnY+YhN7eLGYTlw1HhDVrVjxwolKn5wIf1ZUSxur4fsaCqHQ3ASweENa/4U+HPoQ9IgT8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxmv0ye8jR9eEsNgwNhCnzmcYNgh+t8m7N+Y4je3HWA/Xpkg4U+ aO/N9j4aFflzktX41WD2o2/oBkdOumcE6aW0CpI4Y3nYIM3XcLLeWq+a1wzrfEdjRiqTRu2gigS 32vXJMJuNEW4nOpbc9mm2kicd5HloTwr3A+gO7qS0WoTx9DDbPE7uOxcqKeLzBAH4elw= X-Gm-Gg: AeBDietuhrhqFl3xjVsV4C632uZDtJj/KOZXnwOaIvZlIQq9LL2HAIzsr8EemepVLaQ 9WzoxmTg6+FnRE/HRz0G/LDajX/bVzeUYdweLEMY9WP/bgTB+rKFEQZCDrQvVA1fs86/LAH7IQ6 U4xSQzgT5//pqq8SXVRjkmMRyh57y67Oc/SfPkUZkdieNUPFIvgD0nq5wPz+JqLzAW8fcqbaSjr Dy4tukvzCNXWZWDHgGGdzl6TeIONQ5KiTH/qrmLOPxs0FZo+IWThrpVmEfDtCDc8gOX9PJpoejZ gPTw0a3USdNVCERh/0ZbnrItoUzgSG3lZxyTXaOfUFDkWdtKtB2hmN6r1RLExixNd7a0weBIRHy i7jnPkjAmuNUfFDp/SqJ85xiSIV3G0axpWc/duVIoJFdgrcuxQca1Dr2YYwX+MgQ= X-Received: by 2002:a17:902:b493:b0:2b0:c451:ae8a with SMTP id d9443c01a7336-2b5f9eaf437mr21404175ad.13.1776438954310; Fri, 17 Apr 2026 08:15:54 -0700 (PDT) X-Received: by 2002:a17:902:b493:b0:2b0:c451:ae8a with SMTP id d9443c01a7336-2b5f9eaf437mr21403775ad.13.1776438953588; Fri, 17 Apr 2026 08:15:53 -0700 (PDT) Received: from [192.168.1.10] ([122.164.36.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa92c428sm29382555ad.0.2026.04.17.08.15.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 08:15:53 -0700 (PDT) Message-ID: <54b1be0d-1ec3-405c-b1ff-bc759b80e7bc@oss.qualcomm.com> Date: Fri, 17 Apr 2026 20:45:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: sdm630: describe adsp_mem region properly To: Konrad Dybcio , Nickolay Goppen , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20260415-qcom-sdm660-cdsp-adsp-fastrpc-dts-fix-v1-0-03b475b29554@mainlining.org> <20260415-qcom-sdm660-cdsp-adsp-fastrpc-dts-fix-v1-3-03b475b29554@mainlining.org> <70d4dbe7-0e5b-4065-858e-b5a57bbf45e3@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: <70d4dbe7-0e5b-4065-858e-b5a57bbf45e3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Kd7idwYD c=1 sm=1 tr=0 ts=69e24eab cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=XANuBpsXGvULjGEGCPeV4Q==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=Gv3PURsRAAAA:20 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=OuZLqq7tAAAA:8 a=uZtfZZKPeAmlM9mCzUkA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=AKGiAy9iJ-JzxKVHQNES:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-GUID: 7tVLNO36yXhCqSQeliYMuqiO0yCqUWZO X-Proofpoint-ORIG-GUID: 7tVLNO36yXhCqSQeliYMuqiO0yCqUWZO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDE1NCBTYWx0ZWRfX3w19B1nkabhD F0zVhgpEahpAl6z/EVY0SAAyhjMsE/t6mxZoOzHkbdhqvoCLoADPeXVIk/3KS19eKUmcbfn2pYk NUlrErEfwdbvfdcRxDkhEsekAU17hF7WMhPX6YHX9mCnLoO8h9cUlDAoHUxb62E2q+1Z7HmZHlg o8qE4VcC3sHgCWEBWwi6gAsb2pLEEE9MjRjcVxb84nvsq14+ZxZ8ewKL1fNm257Qka+gMBmqPRj CA9tq1DDubFkH/oELJOmYdIi1Xmoz13F/HlaIq7vWYvuZJ0+AJ3NF3V89h9k+mxkvoM572s/0GJ RYyjIP7hTNYvnLF6O/gl3iOrXXy13/1MURZVrGLETS2taNoJtjO4Yy5+hU/MyK6W88GHw30gyvM voUoJtNY546WIJx9gOdkw0Tz/VG5noPsyLMdIeq0qmJDjpTdNjlSzPXoREFK/alXGTSFwd0ptMh mIQiNKEvbQ+ydP9OIHw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-17_01,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170154 On 15-04-2026 15:22, Konrad Dybcio wrote: > On 4/15/26 11:40 AM, Nickolay Goppen wrote: >> Downstream [1] this region is marked as shared and reusable so >> describe it that way. >> >> [1]: https://github.com/xiaomi-sdm660/android_kernel_xiaomi_sdm660/blob/11-EAS/arch/arm/boot/dts/qcom/sdm660.dtsi#L448 >> >> Signed-off-by: Nickolay Goppen >> --- > > +Ekansh some insight, please? > > We're giving away that memory via qcom_scm_assign_mem() anyway > and I would assume that making it not-"no-map" could introduce issues > when the OS tries to access that region > With the current version and the upcoming planned enhancements, I don't see any major benefits of making this as not-"no-map". With posted enhancements[1], the plan is to qcom_scm_assign_mem() the entire memory-region to lpass VMIDs. and un-assign it only during fastrpc_rpmsg_remove(). There have been implementation in downstream where this memory is dumped in case of SSR or audio PDR using minidump, so marking it `reusable` might make sense there, but that dump logic is not added upstream. Upon checking the DT, I see a bigger problem here, this memory-region looks to me unused, it's not added under fastrpc adsp node(ref. [2]). Please correct me if I am wrong about this point. [1] https://lore.kernel.org/all/20260409062617.1182-1-jianping.li@oss.qualcomm.com/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/lemans.dtsi#n7500 //Ekansh > Konrad > > >> arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> index 4b47efdb57b2..13094b5e9339 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> @@ -495,8 +495,9 @@ venus_region: venus@9f800000 { >> }; >> >> adsp_mem: adsp-region@f6000000 { >> + compatible = "shared-dma-pool"; >> reg = <0x0 0xf6000000 0x0 0x800000>; >> - no-map; >> + reusable; >> }; >> >> qseecom_mem: qseecom-region@f6800000 { >>