From: Markus Elfring <Markus.Elfring@web.de>
To: Matthew Wilcox <willy@infradead.org>,
virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
Miklos Szeredi <miklos@szeredi.hu>,
Stefan Hajnoczi <stefanha@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] virtiofs: Improve error handling in virtio_fs_get_tree()
Date: Fri, 29 Dec 2023 10:10:08 +0100 [thread overview]
Message-ID: <54b353b6-949d-45a1-896d-bb5acb2ed4ed@web.de> (raw)
In-Reply-To: <ZY6Iir/idOZBiREy@casper.infradead.org>
>> The kfree() function was called in two cases by
>> the virtio_fs_get_tree() function during error handling
>> even if the passed variable contained a null pointer.
>
> So what? kfree(NULL) is perfectly acceptable.
I suggest to reconsider the usefulness of such a special function call.
> Are you trying to optimise an error path?
I would appreciate if further improvements can be achieved.
https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources
Regards,
Markus
next prev parent reply other threads:[~2023-12-29 9:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 8:34 [PATCH 0/2] virtiofs: Adjustments for two function implementations Markus Elfring
2023-12-29 8:36 ` [PATCH 1/2] virtiofs: Improve three size determinations Markus Elfring
2024-01-02 20:41 ` Vivek Goyal
2023-12-29 8:38 ` [PATCH 2/2] virtiofs: Improve error handling in virtio_fs_get_tree() Markus Elfring
2023-12-29 8:51 ` Matthew Wilcox
2023-12-29 9:10 ` Markus Elfring [this message]
2023-12-29 14:21 ` Matthew Wilcox
2024-01-02 9:35 ` [2/2] " Markus Elfring
2024-01-02 10:17 ` Matthew Wilcox
2024-01-02 10:47 ` Markus Elfring
2024-01-02 16:28 ` Matthew Wilcox
2024-01-02 16:50 ` Markus Elfring
2024-01-02 20:21 ` [PATCH 2/2] " Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54b353b6-949d-45a1-896d-bb5acb2ed4ed@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox