From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80F504028F9; Fri, 10 Jul 2026 10:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783679079; cv=none; b=JvjkiVM6Yx/DmB06dxY3EQ8wl0tMvEcpTsJSbObix96RyLrZlku3qmbMGWxCr+s35WeYPpCEyExZx2ULeg8Btql20mtlLAgAp2xCBO5D1e+w59l5V6p9jHArCKjrX+3vf7GOfmTOwij8vx/gcSrZ6I2EqJgKHJ1skliKhxqGx+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783679079; c=relaxed/simple; bh=7tJ9sDFyVo6pkgS5tUQdZYgwITLYC/SeKMhjhyorwOw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Rwh9mOR1UrOx5Q96mWvoOzpCXJXnBkWDQ87quxRXxvyohXQZRkq3o6ywwQHfdo8ta7rFimHnnw5yAl7rBbJZ5gR7fNZAOz7ikCX0jHzrbGZtQX/I01k5ngMyn5vi+kSXLLZePaXyGBGUlBUk02kCYjTk24AbRNtS/Q8EEtKwdrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KS7m8lIQ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KS7m8lIQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D55741F000E9; Fri, 10 Jul 2026 10:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783679078; bh=0lSg57AZY9eBuZZ9Ccwy949KbkZaKqh3Pl+LQx3tnuk=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=KS7m8lIQ6LYuu+ZK3bQngjwvfLvq9uvDCmNvZtpgwxlysA/0Q/1EXQ0w+IQFJTIgD O4Yv6qDQhXjpij+IP2e/lv77HzQhXbiQ7sX+1jlaXBhfvYxX9os+/XRjqFLoikQ5pK ZHbA9M5Y4K0iVqJjTDUZysp8gU9UhCAr2h3EZuSTy9GY9L0KvLQQsJb5LGsi2P5wD9 QC89GFmYTO506J5cVj/SAd29uhkc9ymcOCKQ/S4EnRTDpwjyxxK5L1SzDCPF0KsJsX 8DtLq1ah6BXCCaVE6O81hkfMjW3E1i6c0C62dAe2LPmLBVPdVVSPZtk1BoroHB7Pzp /uYJF4D/kMmbw== Message-ID: <54c419d0-b0cb-4add-8d74-94a40804f33e@kernel.org> Date: Fri, 10 Jul 2026 12:24:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk To: Alim Akhtar , 'Peter Griffin' Cc: robh@kernel.org, conor+dt@kernel.org, linusw@kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, hajun.sung@samsung.com References: <20260627171228.2687857-1-alim.akhtar@samsung.com> <20260627171228.2687857-6-alim.akhtar@samsung.com> <14cf01dd1052$4de88670$e9b99350$@samsung.com> <9eb6b0ef-cbc1-4b2f-b607-986f28ec46ee@kernel.org> <14e201dd1055$b7173940$2545abc0$@samsung.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <14e201dd1055$b7173940$2545abc0$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/07/2026 12:20, Alim Akhtar wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Friday, July 10, 2026 3:30 PM >> To: Alim Akhtar ; 'Peter Griffin' >> >> Cc: robh@kernel.org; conor+dt@kernel.org; linusw@kernel.org; linux-samsung- >> soc@vger.kernel.org; linux-kernel@vger.kernel.org; >> devicetree@vger.kernel.org; linux-gpio@vger.kernel.org; >> hajun.sung@samsung.com >> Subject: Re: [PATCH v3 5/6] arm64: dts: exynos: add initial support for Samsung >> Exynos8855 smdk >> >> On 10/07/2026 11:55, Alim Akhtar wrote: >>>>> --- >>>>> arch/arm64/boot/dts/exynos/Makefile | 1 + >>>>> .../boot/dts/exynos/exynos8855-pinctrl.dtsi | 574 ++++++++++++++++++ >>>>> .../arm64/boot/dts/exynos/exynos8855-smdk.dts | 32 + >>>>> arch/arm64/boot/dts/exynos/exynos8855.dtsi | 204 +++++++ >>>>> 4 files changed, 811 insertions(+) >>>>> create mode 100644 >>>>> arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi >>>>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-smdk.dts >>>>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8855.dtsi >>>>> + }; >>> [snip] >>>>> + >>>>> + oscclk: clock-oscclk { >>>>> + compatible = "fixed-clock"; >>>>> + clock-output-names = "oscclk"; >>>>> + #clock-cells = <0>; >>>>> + }; >>>> >>>> Small nit, but I believe oscclk node should be ordered >>>> alpha-numerically by the node name. See >>>> https://docs.kernel.org/devicetree/bindings/dts-coding- >>>> style.html >>>> >>> Thanks, will update in v4 >> >> >> The node feels ordered, no? clock before cpu? >> > Right, " ordered alpha-numerically by the node name" > > Krzysztof, do you want to send v4 with all the reviewed-by tag collected? No need, there are no changes planned, right? I just give it a day or two if Peter or someone wants to review this one in such case. Best regards, Krzysztof