From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB2D437757D for ; Tue, 25 Aug 2026 06:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639742; cv=none; b=dxRNbaxDvJfbs8i2NoSP4bphaEQkK0EUbSIIpyZflyO0S5qYiTVWX/107vIV3Gr8RHsOs6aSJYo4WM1Vh5u6Sg6zwi5u/jk/5I8t3vxkmOm7tJkUv5SzrQ9F1H1YZFs0f2lRRT9efeYJW19Cm+oNpOMRCUm+jB7nR2tLbxfCiG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639742; c=relaxed/simple; bh=OYFTnH7Tc99aLmYcySQnt8hI7Iz/S/Gw0VfBDFPigtA=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=AwOI+w0QKqxNIlQZdg9IjkFHCRpFHTD3FTJUnkDWgFm3wOuFmcKd6CteZa2CYgOeBhtDTKIGjrQfTzj/eryWbRdSeLrlICvP4UuObrpeFfvvmTYFv5IUV18zsNToXPvhiEEpcmsPqXzeKFUA5mJCIU0T9i87z9dh7duosV46WJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m8+gtRPm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m8+gtRPm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E8571F000E9; Tue, 25 Aug 2026 06:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787639741; bh=7T4e1XtewZaaSN4eTuSLlf7noxajHwVsSl6GIgpNduo=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=m8+gtRPmqVscM+FfeBkjPw7EX5rMbuvsW1Vuk0h9YNQOzEkfVgx+C9xEs5CKcSmJ8 cyeqJc732WDZZgC13qw+k67xLhDM50DZzNiHw58ndzr4ZFBNoGJEPNGoNf4idSxjcw EBSeDFfF0l/zPBcQp/liSmtkr7VGvB+J6KRyvchKc5KJgdv3co8BcFva/gms5kyTp+ vm0RlPa3MdertUcx/nq/XzbGNnDBhTkGOWBBQqDkzKULEylUQLWySn66+l6MLv3sTv ReFbyFvOC994UQDFPSO+BQNAi9pjJw/E7GhkNvx8GsYAXPzYEM6kxmj9vTsePPiPeb /5/OLrnPGUOTQ== Message-ID: <54d08d5d-297f-4736-bcd5-133b089d093f@kernel.org> Date: Tue, 25 Aug 2026 14:35:38 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Jaegeuk Kim , qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 01/12] f2fs: cache: implement metadata cache To: Wenjie Qi References: <20260824134731.3704352-1-chao@kernel.org> <20260824134731.3704352-2-chao@kernel.org> <20260825053959.395465-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260825053959.395465-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/25/26 13:39, Wenjie Qi wrote: > Hi Chao, > >> next: >> spin_lock_irqsave(&cache->tree_lock, flags); >> nr = radix_tree_gang_lookup(&cache->root, (void **)entries, index, >> min((unsigned long)F2FS_ONSTACK_CACHES, end - index)); >> ... >> spin_unlock_irqrestore(&cache->tree_lock, flags); >> ... >> if (index < end) >> goto next; > > `nr` bounds each gang lookup, while the outer loop continues until `index` > reaches `end`. Dropping `tree_lock` between batches is not itself a > scheduling point. > > Is there a scheduling point or another bound on the number of entries that > this range invalidation can process in one invocation? Wenjie, I think it's good to have cond_resched() before "goto next", will fix in below cases: - f2fs_cache_wait_on_all_writeback - f2fs_drop_cache_range - f2fs_invalidate_compress_pages Thanks,