From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbbCKJ41 (ORCPT ); Wed, 11 Mar 2015 05:56:27 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:45224 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbbCKJ4Y (ORCPT ); Wed, 11 Mar 2015 05:56:24 -0400 X-AuditID: cbfee690-f79ab6d0000046f7-e3-55001146cd54 Message-id: <55001146.3040304@samsung.com> Date: Wed, 11 Mar 2015 18:56:22 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Sergei Shtylyov , Javier Martinez Canillas , Arnd Bergmann , Olof Johansson Subject: Re: [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name References: <1426067672-21589-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1426067672-21589-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsWyRsSkWNdNkCHU4NBHOYu/k46xWxz9XWDx +oWhRf/j18wWmx5fY7W4vGsOm8WM8/uYLE5d/8xmcWbVLXYHTo/fvyYxejyY+p/J4+/z6ywe m1Z1snlsXlLvceVEE6tH35ZVjB6fN8kFcERx2aSk5mSWpRbp2yVwZUz5Vl7QxVtx9Pgf1gbG yVxdjJwcEgImEt87d7FC2GISF+6tZ+ti5OIQEljKKHFl92V2mKLW841MEIlFjBJ/Xh0ASwgJ vGaUeN6lDmLzCmhJTHj0AizOIqAq0fLjD9hUNqD4/hc32EBsUYEwiZXTr7BA1AtK/Jh8D8wW ETCUOLh7O9gCZoFDTBILN58HSwgLhEj0PJoAtcxdYsKuvWBxTgEPiWlTVoLZzAI6Evtbp7FB 2PISm9e8ZQYZJCHwkl2if8U6RoiLBCS+TT4E1MABlJCV2HSAGeIzSYmDK26wTGAUm4XkpllI xs5CMnYBI/MqRtHUguSC4qT0IhO94sTc4tK8dL3k/NxNjMAYPf3v2YQdjPcOWB9iFOBgVOLh 9Zj/P0SINbGsuDL3EKMp0BUTmaVEk/OBiSCvJN7Q2MzIwtTE1NjI3NJMSZz3tdTPYCGB9MSS 1OzU1ILUovii0pzU4kOMTBycUg2MLar6N9Q6DW6fC7mScmLh1f9nG11/pq9ptYhpE1v+a0qM sYjElY9T9lYY5x3/+WyDstCLf56ZjrMqEzusV/M69Sa3t9tEGRuVB5psbsix0T87+cnXqRbH zp88y53gta9HoXVSxUT9oAD9gAWt3898DcldP9FnRtexC3sbq77t0pbc9ElsbuA9JZbijERD Leai4kQA7EukZswCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42I5/e+xgK6bIEOowcPHYhZ/Jx1jtzj6u8Di 9QtDi/7Hr5ktNj2+xmpxedccNosZ5/cxWZy6/pnN4syqW+wOnB6/f01i9Hgw9T+Tx9/n11k8 Nq3qZPPYvKTe48qJJlaPvi2rGD0+b5IL4IhqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUz MNQ1tLQwV1LIS8xNtVVy8QnQdcvMAbpOSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBc j5EBGkhYw5gx5Vt5QRdvxdHjf1gbGCdzdTFyckgImEi0nm9kgrDFJC7cW8/WxcjFISSwiFHi z6sD7CAJIYHXjBLPu9RBbF4BLYkJj16AxVkEVCVafvxhBbHZgOL7X9xgA7FFBcIkVk6/wgJR LyjxY/I9MFtEwFDi4O7tTCALmAUOMUks3HweLCEsECLR82gC1DJ3iQm79oLFOQU8JKZNWQlm MwvoSOxvncYGYctLbF7zlnkCo8AsJDtmISmbhaRsASPzKkbR1ILkguKk9FxDveLE3OLSvHS9 5PzcTYzgBPBMagfjygaLQ4wCHIxKPLwe8/+HCLEmlhVX5h5ilOBgVhLh7eNnCBXiTUmsrEot yo8vKs1JLT7EaAoMgonMUqLJ+cDklFcSb2hsYmZkaWRuaGFkbK4kzqtk3xYiJJCeWJKanZpa kFoE08fEwSnVwKhmeMCX/ee62zYZ8h9f7VVRnedoUDz1MJOQj9OW+4LVe499TCz5LuT9i4Hn XLpz4f/2FouFjDNq/s+7rNuZ07gnI/tHdW7jXCvPnjDuq3uFDJ4eSeC6lLpPo+lw4UVBYW9v YXO7ezKueu26TxMXTRVb5rkwSULpmDiL4Hou05O37HZb/JHer8RSnJFoqMVcVJwIAL1aXjAW AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2015 06:54 PM, Krzysztof Kozlowski wrote: > The power domain nodes in DTS may be very generic (e.g. "power-domain" > for Exynos 5420) making it very hard to debug: > > $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary > domain status slaves > power-domain on > > Use platform device name instead so the names will be a little more user > friendly: > domain status slaves > 100440e0.power-domain on > > Signed-off-by: Krzysztof Kozlowski > Suggested-by: Javier Martinez Canillas > Suggested-by: Sergei Shtylyov > Reviewed-by: Javier Martinez Canillas > --- > > Notes: > Changes since v1: > 1. Add Javier's reviewed-by. > > arch/arm/mach-exynos/pm_domains.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c > index 37266a826437..84e1d9f4d76c 100644 > --- a/arch/arm/mach-exynos/pm_domains.c > +++ b/arch/arm/mach-exynos/pm_domains.c > @@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void) > return -ENOMEM; > } > > - pd->pd.name = kstrdup(np->name, GFP_KERNEL); > + pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL); > pd->name = pd->pd.name; > pd->base = of_iomap(np, 0); > pd->pd.power_off = exynos_pd_power_off; > Looks good to me. This patch is very useful for debug. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi