From: Michal Marek <mmarek@suse.cz>
To: Mikko Rapeli <mikko.rapeli@iki.fi>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Javier Barrio <javier.barrio.mart@gmail.com>
Subject: Re: [PATCH 03/45] headers_install.sh: enhance error handling
Date: Wed, 11 Mar 2015 11:16:11 +0100 [thread overview]
Message-ID: <550015EB.2010601@suse.cz> (raw)
In-Reply-To: <20150310224448.GW12550@lakka.kapsi.fi>
On 2015-03-10 23:44, Mikko Rapeli wrote:
> On Tue, Feb 17, 2015 at 02:17:51PM +0100, Michal Marek wrote:
>> On 2015-02-17 00:05, Mikko Rapeli wrote:
>>> Exit with error if using undefined variables or if any sub command fails
>>> with error return value. unidef needs special handling since but this can
>>> be done without the trap. Enables exaniming intermediate files if some
>>> commands failed.
>>
>> The intermediate files are removed by your patch as well, aren't they?
>> Actually, I don't see any change in behavior after your patch.
>
> Yes, if everything succeeded without errors, then intermediate files
> are removed. But the files are left around if something fails
They are not:
+ "$SRCDIR/$i" > "$OUTDIR/$FILE.sed" || \
+ ( rm -f "$OUTDIR/$FILE.sed" ; exit 1 )
This removes "$OUTDIR/$FILE.sed" if the sed command files. Just like the
trap command has been doing.
Michal
next prev parent reply other threads:[~2015-03-11 10:16 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 23:05 [PATCH RFC v02 00/45] Compile test and fixes for exported header files Mikko Rapeli
2015-02-16 23:05 ` [PATCH 01/45] Makefile: propagate verbose options Mikko Rapeli
2015-02-17 7:18 ` Masahiro Yamada
2015-03-10 22:36 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 02/45] scripts/headers.sh: add verbose option to make calls if defined Mikko Rapeli
2015-02-17 7:18 ` Masahiro Yamada
2015-03-10 22:37 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 03/45] headers_install.sh: enhance error handling Mikko Rapeli
2015-02-17 13:17 ` Michal Marek
2015-03-10 22:44 ` Mikko Rapeli
2015-03-11 10:16 ` Michal Marek [this message]
2015-03-11 10:24 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 04/45] scripts/headers_compile_test.sh: compile test script for exported headers Mikko Rapeli
2015-02-16 23:05 ` [PATCH 05/45] drm.h: include stdlib.h in userspace Mikko Rapeli
2015-02-23 10:26 ` Emil Velikov
2015-02-23 10:35 ` Mikko Rapeli
2015-03-20 20:25 ` Emil Velikov
2015-03-21 12:17 ` Mikko Rapeli
2015-04-09 16:00 ` Emil Velikov
2015-04-09 16:09 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 06/45] drm_mode.h: include stdint.h and linux/types.h " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 07/45] exynos_drm.h: include stdint.h " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 08/45] nouveau_drm.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 09/45] radeon_drm.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 10/45] r128_drm.h: include drm/drm.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 11/45] via_drm.h: include linux/types.h instead of non-existing via_drmclient.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 12/45] via_drm.h: hide struct via_file_private in userspace Mikko Rapeli
2015-02-16 23:05 ` [PATCH 13/45] savage_drm.h: include <drm/drm.h> Mikko Rapeli
2015-02-16 23:05 ` [PATCH 14/45] sis_drm.h: hide sis_file_private in userspace Mikko Rapeli
2015-02-16 23:05 ` [PATCH 15/45] dm-log-userspace.h: include stdint.h " Mikko Rapeli
2015-02-16 23:32 ` Mike Snitzer
2015-02-16 23:48 ` Mikko Rapeli
2015-02-17 9:08 ` Arnd Bergmann
2015-02-17 13:38 ` Alasdair G Kergon
2015-02-17 13:55 ` Arnd Bergmann
2015-03-10 22:48 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 16/45] hsi_char.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 17/45] ebtables.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 18/45] cld.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 19/45] rds.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 20/45] sctp.h: " Mikko Rapeli
2015-02-17 13:11 ` Neil Horman
2015-02-18 15:48 ` Daniel Borkmann
2015-02-18 16:05 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 21/45] scsi_bsg_fc.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 22/45] scsi_netlink.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 23/45] scsi_netlink_fc.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 24/45] hdspm.h: " Mikko Rapeli
2015-02-17 6:46 ` Takashi Iwai
2015-03-11 0:28 ` Mikko Rapeli
2015-03-11 6:09 ` Takashi Iwai
2015-02-16 23:05 ` [PATCH 25/45] gntalloc.h: " Mikko Rapeli
2015-02-18 11:53 ` [Xen-devel] " David Vrabel
2015-03-10 22:48 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 26/45] gntdev.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 27/45] include/uapi/linux/sysctl.h: include stdlib.h " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 28/45] include/uapi/asm-generic/ipcbuf.h: include linux/posix_types.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 29/45] include/uapi/asm-generic/msgbuf.h: include asm/ipcbuf.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 30/45] include/uapi/asm-generic/shmbuf.h: include fixes Mikko Rapeli
2015-02-16 23:05 ` [PATCH 31/45] asm-generic/sembuf.h: include asm/posix_types.h and asm/ipcbuf.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 32/45] drm/i810_drm.h: include drm/drm.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 33/45] include/uapi/asm-generic/signal.h: include stdlib.h in userspace Mikko Rapeli
2015-02-17 9:44 ` Arnd Bergmann
2015-03-10 22:58 ` Mikko Rapeli
2015-03-11 10:02 ` Arnd Bergmann
2015-02-16 23:05 ` [PATCH 34/45] include/uapi/asm-generic/signal.h: hide sigset_t definition " Mikko Rapeli
2015-02-17 9:16 ` Arnd Bergmann
2015-03-11 0:05 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 35/45] include/uapi/sound/asound.h: include stdlib.h " Mikko Rapeli
2015-02-17 6:46 ` Takashi Iwai
2015-02-16 23:05 ` [PATCH 36/45] include/uapi/linux/netfilter.h: include in.h and in6.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 37/45] include/uapi/linux/socket.h: include sys/socket.h in userspace Mikko Rapeli
2015-02-17 9:14 ` Arnd Bergmann
2015-03-11 0:38 ` Mikko Rapeli
2015-03-11 0:59 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 38/45] include/uapi/linux/agpgart.h: include stdlib.h " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 39/45] include/uapi/sound/asequencer.h: include sound/asound.h Mikko Rapeli
2015-02-17 6:46 ` Takashi Iwai
2015-02-16 23:05 ` [PATCH 40/45] include/uapi/sound/emu10k1.h: " Mikko Rapeli
2015-02-17 6:46 ` Takashi Iwai
2015-02-16 23:05 ` [PATCH 41/45] include/uapi/sound/emu10k1.h: hide gpr_valid, tram_valid and code_valid in userspace Mikko Rapeli
2015-02-17 6:27 ` Takashi Iwai
2015-03-11 1:22 ` Mikko Rapeli
2015-03-11 6:11 ` Takashi Iwai
2015-03-11 9:46 ` Arnd Bergmann
2015-03-12 6:11 ` Takashi Iwai
2015-03-12 8:45 ` Arnd Bergmann
2015-03-12 9:05 ` Takashi Iwai
2015-02-16 23:05 ` [PATCH 42/45] include/uapi/linux/rds.h: include linux/socket.h and linux/types.h always Mikko Rapeli
2015-02-16 23:05 ` [PATCH 43/45] include/uapi/linux/netfilter_bridge.h: include if.h Mikko Rapeli
2015-02-17 0:02 ` Jan Engelhardt
2015-03-11 1:49 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 44/45] nf_conntrack_tuple_common.h: include linux/types.h and linux/netfilter.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 45/45] include/uapi/asm-generic/ucontext.h: include signal.h and sigcontext.h Mikko Rapeli
2015-02-17 9:10 ` Arnd Bergmann
2015-03-11 1:59 ` Mikko Rapeli
2015-02-18 16:16 ` [PATCH RFC v02 00/45] Compile test and fixes for exported header files Mikko Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550015EB.2010601@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=javier.barrio.mart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikko.rapeli@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox