From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbbCKLBC (ORCPT ); Wed, 11 Mar 2015 07:01:02 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:44944 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbbCKLA6 (ORCPT ); Wed, 11 Mar 2015 07:00:58 -0400 Message-ID: <55002065.9070206@collabora.co.uk> Date: Wed, 11 Mar 2015 12:00:53 +0100 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Mark Brown CC: Doug Anderson , Liam Girdwood , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] regulator: Only enable disabled regulators on resume References: <1425328839-28330-1-git-send-email-javier.martinez@collabora.co.uk> <54F60602.3030505@collabora.co.uk> <54F70C5C.4080201@collabora.co.uk> <20150308193812.GW28806@sirena.org.uk> <54FD4E64.2070909@collabora.co.uk> <20150311105744.GX28806@sirena.org.uk> In-Reply-To: <20150311105744.GX28806@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2015 11:57 AM, Mark Brown wrote: > On Mon, Mar 09, 2015 at 08:40:20AM +0100, Javier Martinez Canillas wrote: >> On 03/08/2015 08:38 PM, Mark Brown wrote: >> > You mean _do_enable(), not _enable() here. It's not really a leftover > >> No, I meant _enable() here. What I said is that _enable() is checking >> if -EINVAL was returned by _is_enabled(): > > Then we have an abstraction problem if we're trying to do things in > plain _enable() - _do_enable() is supposed to be hiding all this stuff. > Agreed. Best regards, Javier