From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbbCKMso (ORCPT ); Wed, 11 Mar 2015 08:48:44 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:58730 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753012AbbCKMsk (ORCPT ); Wed, 11 Mar 2015 08:48:40 -0400 Message-ID: <550039A2.9010307@atmel.com> Date: Wed, 11 Mar 2015 13:48:34 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: , CC: , , , , Boris BREZILLON , Alexandre Belloni Subject: Re: [PATCH] backlight: pwm: handle EPROBE_DEFER while requesting the PWM References: <1424338214-24236-1-git-send-email-nicolas.ferre@atmel.com> In-Reply-To: <1424338214-24236-1-git-send-email-nicolas.ferre@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 19/02/2015 10:30, Nicolas Ferre a écrit : > When trying to request the PWM device with devm_pwm_get(), the EPROBE_DEFER > flag is not handled properly. It can lead to the PWM not being found. > > Signed-off-by: Boris Brezillon > Signed-off-by: Nicolas Ferre Any comment on this patch? Can we see it included during next cycle (4.1)? (aka ping). Bye, > --- > drivers/video/backlight/pwm_bl.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index 3a145a643e0d..6897f1c1bc73 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -274,6 +274,10 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->pwm = devm_pwm_get(&pdev->dev, NULL); > if (IS_ERR(pb->pwm)) { > + ret = PTR_ERR(pb->pwm); > + if (ret == -EPROBE_DEFER) > + goto err_alloc; > + > dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n"); > pb->legacy = true; > pb->pwm = pwm_request(data->pwm_id, "pwm-backlight"); > -- Nicolas Ferre