From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbbCKNSO (ORCPT ); Wed, 11 Mar 2015 09:18:14 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54741 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752457AbbCKNSM (ORCPT ); Wed, 11 Mar 2015 09:18:12 -0400 Message-ID: <5500408B.2070604@osg.samsung.com> Date: Wed, 11 Mar 2015 07:18:03 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman CC: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, mmarek@suse.cz, linux-api@vger.kernel.org Subject: Re: [PATCH v4 4/9] selftests: Add install target References: <1426046765-19289-1-git-send-email-mpe@ellerman.id.au> <1426046765-19289-4-git-send-email-mpe@ellerman.id.au> In-Reply-To: <1426046765-19289-4-git-send-email-mpe@ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2015 10:06 PM, Michael Ellerman wrote: > This adds make install support to selftests. The basic usage is: > > $ cd tools/testing/selftests > $ make install > > That installs into tools/testing/selftests/install, which can then be > copied where ever necessary. > > The install destination is also configurable using eg: > > $ INSTALL_PATH=/mnt/selftests make install > > The implementation uses two targets in the child makefiles. The first > "install" is expected to install all files into $(INSTALL_PATH). > > The second, "emit_tests", is expected to emit the test instructions (ie. > bash script) on stdout. Separating this from install means the child > makefiles need no knowledge of the location of the test script. > > Signed-off-by: Michael Ellerman > --- > > v3: Rebase onto 4.0-rc2. > Rename all.sh to run_kselftest.sh. > Add --no-print-directory to emit_tests invocation. > v4: Rebase onto 4.0-rc3, add TEST_FILES to efivars and vm tests, remove > newlines from echoes. I don't see my comments addressed. If you want me to take this work, please address the following comments: - Name install directory kselftest. It should work with the the use-case. make INSTALL_PATH=/tmp make install The install directory should be /tmp/kselftest - Flatten the directory with all tests under /tmp/kselftest I am wasting lot of time because you don't fully address my comments and send patches that dont' work correctly. Please make sure your patches don't generate work for me. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978