From: Shuah Khan <shuahkh@osg.samsung.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Prarit Bhargava <prarit@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 00/19 v3] Add timekeeping tests to kernel selftest
Date: Wed, 11 Mar 2015 11:04:56 -0600 [thread overview]
Message-ID: <550075B8.7060208@osg.samsung.com> (raw)
In-Reply-To: <CALAqxLVnVo=tRkjrP10h2ZfmtY+C1CRY448jXi0hva5MgOrU-Q@mail.gmail.com>
On 03/11/2015 10:53 AM, John Stultz wrote:
> On Wed, Mar 11, 2015 at 9:43 AM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> On 03/02/2015 02:09 PM, John Stultz wrote:
>>> I've hosted my timekeeping tests on github for the last few years:
>>> https://github.com/johnstultz-work/timetests
>>>
>>> but I suspect not too many folks have actually used them.
>>>
>>> I've been meaning to get them reworked and submitted into the
>>> selftest infrastructure, but haven't had much time until
>>> recently.
>>>
>>> I've added both the non-desctructive and destructive tests
>>> (which set the time, possibly to strange values, or tries
>>> to trigger historical issues that could crash the machine).
>>> The destructive tests are run (as root, or with proper
>>> privledge) via:
>>> # make run_destructive_tests
>>>
>>> Changes in v3:
>>> * Lots of -Wall build warning fixups
>>> * Handle the CROSS_COMPILER build variable properly
>>> (Thanks to LinusW for pointing that out)
>>> * Integrate w/ ksft_exit_* infrastructure
>>>
>>> Let me know if there is any further comments or feedback!
>>>
>>
>> Ran into several checkpatch warnings when I tried to queue
>> these up for 4.1. Could you please fix them and resend.
>
> So the only few items I saw were:
> 1) Lines over 80 col, usually do to long string output
> 2) String output split over multiple lines (result of trying to fix #1
> in a few spots)
> - And here I did try to split the string sanely so I didn't break
> up the messages, so they're still grepable
> 3) The extern char *optarg, warning. This one I can probably kill
> since I'm including unistd.h.
>
> I'll take a look at #3, but #1 and #2 are basically contrary at a
> certain point. Or do you have other ideas for resolving those
> warnings?
Here are the errors git am flagged:
Patch07:
Applying: selftests/timers: Add set-timer-lat test from timetest suite
/lkml/linux_4.0/.git/rebase-apply/patch:246: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Patch11
Applying: selftests/timers: Add alarmtimer-suspend test from timetests suite
/lkml/linux_4.0/.git/rebase-apply/patch:222: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Patch18
Applying: selftests/timers: Add set-2038 test from timetest suite
/lkml/linux_4.0/.git/rebase-apply/patch:180: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-03-11 17:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 21:09 [PATCH 00/19 v3] Add timekeeping tests to kernel selftest John Stultz
2015-03-02 21:09 ` [PATCH 01/19] selftests/timers: Cleanup Makefile to make it easier to add future tests John Stultz
2015-03-02 21:09 ` [PATCH 02/19] selftests/timers: Quiet warning due to lack of return check on brk John Stultz
2015-03-02 21:09 ` [PATCH 03/19] selftests/timers: Add nanosleep test from timetest suite John Stultz
2015-03-02 21:09 ` [PATCH 04/19] selftests/timers: Add inconsistency-check test from timetests John Stultz
2015-03-02 21:09 ` [PATCH 05/19] selftests/timers: Add nsleep-lat test from timetest suite John Stultz
2015-03-02 21:09 ` [PATCH 06/19] selftests/timers: Add clock skew estimation " John Stultz
2015-03-02 21:10 ` [PATCH 07/19] selftests/timers: Add set-timer-lat " John Stultz
2015-03-02 21:10 ` [PATCH 08/19] selftests/timers: Add threaded time inconsistency " John Stultz
2015-03-02 21:10 ` [PATCH 09/19] selftests/timers: Add mqueue latency test from the " John Stultz
2015-03-02 21:10 ` [PATCH 10/19] selftests/timers: Add adjtimex validation test from " John Stultz
2015-03-02 21:10 ` [PATCH 11/19] selftests/timers: Add alarmtimer-suspend test from timetests suite John Stultz
2015-03-02 21:10 ` [PATCH 12/19] selftests/timers: Add change_skew test from timetest suite John Stultz
2015-03-02 21:10 ` [PATCH 13/19] selftests/timers: Add skew_consistency test from the timetests suite John Stultz
2015-03-02 21:10 ` [PATCH 14/19] selftests/timers: Add clocksource-switch test from timetest suite John Stultz
2015-03-02 21:10 ` [PATCH 15/19] selftests/timers: Add leap-a-day " John Stultz
2015-03-02 21:10 ` [PATCH 16/19] selftests/timers: Add leapcrash test from the " John Stultz
2015-03-02 21:10 ` [PATCH 17/19] selftests/timers: Add set-tai " John Stultz
2015-03-02 21:10 ` [PATCH 18/19] selftests/timers: Add set-2038 test from " John Stultz
2015-03-02 21:10 ` [PATCH 19/19] MAINTAINERS: Add selftests/timers to the timekeeping maintainance list John Stultz
2015-03-03 12:14 ` [PATCH 00/19 v3] Add timekeeping tests to kernel selftest Prarit Bhargava
2015-03-11 16:43 ` Shuah Khan
2015-03-11 16:53 ` John Stultz
2015-03-11 17:04 ` Shuah Khan [this message]
2015-03-11 17:10 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550075B8.7060208@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox