From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752948AbbCKWUF (ORCPT ); Wed, 11 Mar 2015 18:20:05 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:40055 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbbCKWUC (ORCPT ); Wed, 11 Mar 2015 18:20:02 -0400 Message-ID: <5500BF8E.5010104@gmail.com> Date: Wed, 11 Mar 2015 23:19:58 +0100 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Greg KH CC: joe@perches.com, mdcasey@chabloom.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8192e: rtllib_wx: code style improvements References: <1426027985-28827-1-git-send-email-mateusz.kulikowski@gmail.com> <1426059960-11587-1-git-send-email-mateusz.kulikowski@gmail.com> <20150311075330.GA6197@kroah.com> In-Reply-To: <20150311075330.GA6197@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.03.2015 08:53, Greg KH wrote: > On Wed, Mar 11, 2015 at 08:46:00AM +0100, Mateusz Kulikowski wrote: >> Code reformatting based on checkpatch.pl: >> - Replaced min() with min_t() >> - Replaced printk() with netdev_*() >> - Merged broken string > > That's three different things, which means this should be at least 3 > different patches. Please fix up and resend a patch series, as each > patch should only do one thing. Will split in v3 (and do it for future patches). Thanks for the comments, Mateusz