From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753084AbbCKWhB (ORCPT ); Wed, 11 Mar 2015 18:37:01 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50323 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbbCKWhA (ORCPT ); Wed, 11 Mar 2015 18:37:00 -0400 Message-ID: <5500C38A.5070506@codeaurora.org> Date: Wed, 11 Mar 2015 15:36:58 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Antoine Tenart , sebastian.hesselbarth@gmail.com, mturquette@linaro.org CC: zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/11] clk: convert clock mux to accept regmap References: <1425654784-27354-1-git-send-email-antoine.tenart@free-electrons.com> <1425654784-27354-2-git-send-email-antoine.tenart@free-electrons.com> In-Reply-To: <1425654784-27354-2-git-send-email-antoine.tenart@free-electrons.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/15 07:12, Antoine Tenart wrote: > Rework the clk_mux helpers to either use an iomem base address or a > regmap. > > Signed-off-by: Antoine Tenart > Last time we tried this Mike was opposed. The union is a nice trick but I'm not sure it will help much. Perhaps you'd be interested in using the bits of the mux code that you need by using this patch[1]? It makes it so you can use the mux and associated flags as functions called from somewhere else. Building a regmap mux on top of that should be fairly straightforward. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/284935.html -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project