From: Kishon Vijay Abraham I <kishon@ti.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path
Date: Thu, 12 Mar 2015 11:02:43 +0530 [thread overview]
Message-ID: <550124FB.2080506@ti.com> (raw)
In-Reply-To: <1426032383.5707.1.camel@phoenix>
On Wednesday 11 March 2015 05:36 AM, Axel Lin wrote:
> Remove the second lock on non-regmap path.
>
> Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations)
> Reported-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
merged after squashing it with the original patch.
Thanks
Kishon
> ---
> drivers/phy/phy-exynos-mipi-video.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
> index 8d6d117..df7519a 100644
> --- a/drivers/phy/phy-exynos-mipi-video.c
> +++ b/drivers/phy/phy-exynos-mipi-video.c
> @@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state,
> } else {
> addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2);
>
> - spin_lock(&state->slock);
> val = readl(addr);
> if (on)
> val |= reset;
>
prev parent reply other threads:[~2015-03-12 5:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 0:06 [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path Axel Lin
2015-03-12 5:32 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550124FB.2080506@ti.com \
--to=kishon@ti.com \
--cc=Julia.Lawall@lip6.fr \
--cc=axel.lin@ingics.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox