* [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path
@ 2015-03-11 0:06 Axel Lin
2015-03-12 5:32 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-03-11 0:06 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Julia Lawall, Sylwester Nawrocki, Kyungmin Park,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Remove the second lock on non-regmap path.
Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations)
Reported-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/phy-exynos-mipi-video.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
index 8d6d117..df7519a 100644
--- a/drivers/phy/phy-exynos-mipi-video.c
+++ b/drivers/phy/phy-exynos-mipi-video.c
@@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state,
} else {
addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2);
- spin_lock(&state->slock);
val = readl(addr);
if (on)
val |= reset;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path
2015-03-11 0:06 [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path Axel Lin
@ 2015-03-12 5:32 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2015-03-12 5:32 UTC (permalink / raw)
To: Axel Lin
Cc: Julia Lawall, Sylwester Nawrocki, Kyungmin Park,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
On Wednesday 11 March 2015 05:36 AM, Axel Lin wrote:
> Remove the second lock on non-regmap path.
>
> Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations)
> Reported-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
merged after squashing it with the original patch.
Thanks
Kishon
> ---
> drivers/phy/phy-exynos-mipi-video.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
> index 8d6d117..df7519a 100644
> --- a/drivers/phy/phy-exynos-mipi-video.c
> +++ b/drivers/phy/phy-exynos-mipi-video.c
> @@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state,
> } else {
> addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2);
>
> - spin_lock(&state->slock);
> val = readl(addr);
> if (on)
> val |= reset;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-12 5:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-11 0:06 [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path Axel Lin
2015-03-12 5:32 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox