From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751565AbbCLFc6 (ORCPT ); Thu, 12 Mar 2015 01:32:58 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:56044 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbbCLFc5 (ORCPT ); Thu, 12 Mar 2015 01:32:57 -0400 Message-ID: <550124FB.2080506@ti.com> Date: Thu, 12 Mar 2015 11:02:43 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Axel Lin CC: Julia Lawall , Sylwester Nawrocki , Kyungmin Park , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path References: <1426032383.5707.1.camel@phoenix> In-Reply-To: <1426032383.5707.1.camel@phoenix> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 11 March 2015 05:36 AM, Axel Lin wrote: > Remove the second lock on non-regmap path. > > Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations) > Reported-by: Julia Lawall > Signed-off-by: Axel Lin merged after squashing it with the original patch. Thanks Kishon > --- > drivers/phy/phy-exynos-mipi-video.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c > index 8d6d117..df7519a 100644 > --- a/drivers/phy/phy-exynos-mipi-video.c > +++ b/drivers/phy/phy-exynos-mipi-video.c > @@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state, > } else { > addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2); > > - spin_lock(&state->slock); > val = readl(addr); > if (on) > val |= reset; >