From: Quentin Lambert <lambert.quentin@gmail.com>
To: "Dan Carpenter" <dan.carpenter@oracle.com>,
"Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
Cc: Lidza Louina <lidza.louina@gmail.com>,
Mark Hounschell <markh@compro.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Staging: dgnc: Use goto for error handling
Date: Thu, 12 Mar 2015 10:32:40 +0100 [thread overview]
Message-ID: <55015D38.5060100@gmail.com> (raw)
In-Reply-To: <20150312092711.GX10964@mwanda>
On 12/03/2015 10:27, Dan Carpenter wrote:
> On Wed, Mar 11, 2015 at 06:37:30PM +0200, Giedrius Statkevičius wrote:
>> It's still not in staging-testing for some reason :(
>>
> It can take several weeks to get merged. Relax.
>
> regards,
> dan carpenter
>
What should i do concerning that ?
I need to send a second version of this patch anyway to fix the
fact that i inverted 2 statements, namely:
+exit_unlock:
+ if (ld)
+ tty_ldisc_deref(ld);
+ spin_unlock_irqrestore(&ch->ch_lock, flags);
should be
+exit_unlock:
+ spin_unlock_irqrestore(&ch->ch_lock, flags);
+ if (ld)
+ tty_ldisc_deref(ld);
Should I wait these several weeks to send the second version or should
I send a second version fixing this issue a wait for someone to ask me
to solve the conflict ?
Quentin
next prev parent reply other threads:[~2015-03-12 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 14:04 [PATCH 2/3] Staging: dgnc: Use goto for error handling Quentin Lambert
2015-03-11 16:37 ` Giedrius Statkevičius
2015-03-12 9:27 ` Dan Carpenter
2015-03-12 9:32 ` Quentin Lambert [this message]
2015-03-12 9:54 ` Dan Carpenter
2015-03-12 9:58 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55015D38.5060100@gmail.com \
--to=lambert.quentin@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=giedrius.statkevicius@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox