From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753678AbbCLK3b (ORCPT ); Thu, 12 Mar 2015 06:29:31 -0400 Received: from smtp73.iad3a.emailsrvr.com ([173.203.187.73]:59143 "EHLO smtp73.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbbCLK33 (ORCPT ); Thu, 12 Mar 2015 06:29:29 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <55016A81.1000801@mev.co.uk> Date: Thu, 12 Mar 2015 10:29:21 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 To: Joe Perches CC: driverdev-devel@linuxdriverproject.org, Greg Kroah-Hartman , H Hartley Sweeten , linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/56] staging: comedi: introduce comedi_pci.h header References: <1426003875-27653-1-git-send-email-abbotti@mev.co.uk> <1426004716.18060.10.camel@perches.com> In-Reply-To: <1426004716.18060.10.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/03/15 16:25, Joe Perches wrote: > On Tue, 2015-03-10 at 16:10 +0000, Ian Abbott wrote: >> "comedidev.h" includes PCI-specific stuff that gets included by all >> comedi drivers including non-PCI ones. Separate it out into its own >> header "comedi_pci.h". Make the new header include and >> "comedidev.h" so that comedi PCI drivers do not need to include them >> explicitly. > > Isn't the kernel progressing to avoid indirect includes? I could do it that way if you think it would help. Better to redo it before it is committed than after. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-