From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754187AbbCLMXE (ORCPT ); Thu, 12 Mar 2015 08:23:04 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:7372 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030AbbCLMXA (ORCPT ); Thu, 12 Mar 2015 08:23:00 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 12 Mar 2015 05:21:25 -0700 Message-ID: <55018536.2050904@nvidia.com> Date: Thu, 12 Mar 2015 20:23:18 +0800 From: Vince Hsu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Tejun Heo CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 14/17] ata: ahci_tegra: remove power sequence from driver References: <1426162518-7405-1-git-send-email-vinceh@nvidia.com> <1426162518-7405-15-git-send-email-vinceh@nvidia.com> <20150312121912.GJ25944@htj.duckdns.org> In-Reply-To: <20150312121912.GJ25944@htj.duckdns.org> X-Originating-IP: [10.19.108.63] X-ClientProxiedBy: DRBGMAIL101.nvidia.com (10.18.16.20) To HKMAIL104.nvidia.com (10.18.16.13) Content-Type: multipart/mixed; boundary="------------090109030103030308020303" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --------------090109030103030308020303 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc'd Hans. Thanks, Vince On 03/12/2015 08:19 PM, Tejun Heo wrote: > On Thu, Mar 12, 2015 at 08:15:15PM +0800, Vince Hsu wrote: >> We have the generic PM domain support for Tegra SoCs now. So remove the >> duplicated sequence here. >> >> Signed-off-by: Vince Hsu > Can you please repost this patch w/ Hans de Goede > cc'd? Just reposting the patch as a reply to > itself w/ the cc added should do. > > Thanks. > --------------090109030103030308020303 Content-Type: text/x-patch; name="0014-ata-ahci_tegra-remove-power-sequence-from-driver.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0014-ata-ahci_tegra-remove-power-sequence-from-driver.patch" >>From afff7ff2011f2c3f159726ffddeaeec8f62f013e Mon Sep 17 00:00:00 2001 From: Vince Hsu Date: Wed, 14 Jan 2015 11:01:06 +0800 Subject: [PATCH v2 14/17] ata: ahci_tegra: remove power sequence from driver X-NVConfidentiality: public We have the generic PM domain support for Tegra SoCs now. So remove the duplicated sequence here. Signed-off-by: Vince Hsu --- drivers/ata/ahci_tegra.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c index 3a62eb246d80..8151587ddb70 100644 --- a/drivers/ata/ahci_tegra.c +++ b/drivers/ata/ahci_tegra.c @@ -120,12 +120,6 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv) if (ret) return ret; - ret = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_SATA, - tegra->sata_clk, - tegra->sata_rst); - if (ret) - goto disable_regulators; - reset_control_assert(tegra->sata_oob_rst); reset_control_assert(tegra->sata_cold_rst); @@ -140,10 +134,6 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv) disable_power: clk_disable_unprepare(tegra->sata_clk); - - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); - -disable_regulators: regulator_bulk_disable(ARRAY_SIZE(tegra->supplies), tegra->supplies); return ret; @@ -160,7 +150,6 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv) reset_control_assert(tegra->sata_cold_rst); clk_disable_unprepare(tegra->sata_clk); - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); regulator_bulk_disable(ARRAY_SIZE(tegra->supplies), tegra->supplies); } -- 2.1.4 --------------090109030103030308020303--