From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754366AbbCLMgo (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Mar 2015 08:36:44 -0400
Received: from mail-la0-f43.google.com ([209.85.215.43]:41857 "EHLO
	mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753514AbbCLMgl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Mar 2015 08:36:41 -0400
Message-ID: <55018855.9090301@cogentembedded.com>
Date: Thu, 12 Mar 2015 15:36:37 +0300
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Scott Wood <scottwood@freescale.com>, trivial@kernel.org,
        linux-kernel@vger.kernel.org
CC: linux-usb@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers
References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-18-git-send-email-scottwood@freescale.com>
In-Reply-To: <1426130037-17956-18-git-send-email-scottwood@freescale.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 3/12/2015 6:13 AM, Scott Wood wrote:

> Use %pS for actual addresses, otherwise you'll get bad output

    %pS or %ps?

> on arches like ppc64 where %pF expects a function descriptor.

    %pF or %pf? And what is a function descriptor?

> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: linux-usb@vger.kernel.org
> Cc: Felipe Balbi <balbi@ti.com>
[...]

> diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
> index 491082a..89179ab 100644
> --- a/drivers/usb/gadget/function/u_serial.c
> +++ b/drivers/usb/gadget/function/u_serial.c
> @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
>   	unsigned long	flags;
>   	int		status;
>
> -	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
> +	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n",
>   		port->port_num, tty, ch, __builtin_return_address(0));
[...]

WBR, Sergei