From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932146AbbCLNGl (ORCPT ); Thu, 12 Mar 2015 09:06:41 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:22822 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754614AbbCLNGe (ORCPT ); Thu, 12 Mar 2015 09:06:34 -0400 X-AuditID: cbfec7f4-b7f126d000001e9a-98-55018ea63bf3 Message-id: <55018F23.3010402@samsung.com> Date: Thu, 12 Mar 2015 14:05:39 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-version: 1.0 To: Andrzej Hajda , linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Kyungmin Park , Kukjin Kim , javier.martinez@collabora.co.uk, Liquid.Acid@gmx.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC PATCH 2/3] arm/exynos/pm_domains: add support for async-bridge clocks References: <1423139739-19881-1-git-send-email-a.hajda@samsung.com> <1423139739-19881-3-git-send-email-a.hajda@samsung.com> In-reply-to: <1423139739-19881-3-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xq7rL+hhDDdYeEbS4te4cq8X8I0Di ytf3bBZHfxdY9D9+zWxxtukNu8XlXXPYLGac38dk0fXzJ5vF2iN32R24PP4+v87isXjTfjaP Tas62Tzudx9n8ujbsorR4/MmuQC2KC6blNSczLLUIn27BK6MBXeXsRT8EK3oWHaYpYFxumAX IyeHhICJxLvnb1kgbDGJC/fWs3UxcnEICSxllLjzbg4zhPOJUeLQqk9MIFW8AloSl89OYgax WQRUJZbvXcEIYrMJGEr0Hu0Ds0UFIiRO3t3DDlEvKPFj8j2wDSICXhKnZyxiAhnKLDCJSeLW rk6gQRwcwgKREnO680BMIYFaidY1LiDlnAIuEht/nWcECTML6Encv6gFEmYWkJfYvOYt8wRG gVlIFsxCqJqFpGoBI/MqRtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJA4+LKDcfExq0OMAhyM Sjy8EX0MoUKsiWXFlbmHGCU4mJVEeEvbGUOFeFMSK6tSi/Lji0pzUosPMTJxcEo1MAqvV+T8 bb855uKyr6c0q29POnxQWl3VcqdT0O/j1WEXrI7d7DsYKBDzPjrsUcii+1sNvHuUpRnqPvK3 3GxpuTXn9ZprvVOnvJD3V1PivX660Wzl9MwJG84vTqhrPlkn/vtnmf4Ny89Bb1tc29185YWd w27y7KiVyjFUaLOw4W7cIPFnlbzLUyWW4oxEQy3mouJEALfhtClhAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/02/15 13:35, Andrzej Hajda wrote: > Since Exynos5420 there are async-bridges (ASB) between different IPs. These > bridges must be operational during power domain on/off, ie. clocks used > by these bridges should be enabled. > This patch enabled these clocks during domain on/off. > > Signed-off-by: Andrzej Hajda Reviewed-by: Sylwester Nawrocki > --- > arch/arm/mach-exynos/pm_domains.c | 27 +++++++++++++++++++++++---- > 1 file changed, 23 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c > index 0e2bc36..ecff522 100644 > --- a/arch/arm/mach-exynos/pm_domains.c > +++ b/arch/arm/mach-exynos/pm_domains.c > @@ -37,6 +37,7 @@ struct exynos_pm_domain { > struct clk *oscclk; > struct clk *clk[MAX_CLK_PER_DOMAIN]; > struct clk *pclk[MAX_CLK_PER_DOMAIN]; > + struct clk *asb_clk[MAX_CLK_PER_DOMAIN]; > }; > > static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) > @@ -45,14 +46,19 @@ static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) > void __iomem *base; > u32 timeout, pwr; > char *op; > + int i; > > pd = container_of(domain, struct exynos_pm_domain, pd); > base = pd->base; > > + for (i = 0; i < MAX_CLK_PER_DOMAIN; i++) { > + if (IS_ERR(pd->asb_clk[i])) > + break; > + clk_prepare_enable(pd->asb_clk[i]); > + } > + > /* Set oscclk before powering off a domain*/ > if (!power_on) { > - int i; > - > for (i = 0; i < MAX_CLK_PER_DOMAIN; i++) { > if (IS_ERR(pd->clk[i])) > break; > @@ -81,8 +87,6 @@ static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) > > /* Restore clocks after powering on a domain*/ > if (power_on) { > - int i; > - > for (i = 0; i < MAX_CLK_PER_DOMAIN; i++) { > if (IS_ERR(pd->clk[i])) > break; > @@ -92,6 +96,12 @@ static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) > } > } > > + for (i = 0; i < MAX_CLK_PER_DOMAIN; i++) { > + if (IS_ERR(pd->asb_clk[i])) > + break; > + clk_disable_unprepare(pd->asb_clk[i]); > + } > + > return 0; > } > > @@ -137,6 +147,15 @@ static __init int exynos4_pm_init_power_domain(void) > pd->pd.power_off = exynos_pd_power_off; > pd->pd.power_on = exynos_pd_power_on; > > + for (i = 0; i < MAX_CLK_PER_DOMAIN; i++) { > + char clk_name[8]; > + > + snprintf(clk_name, sizeof(clk_name), "asb%d", i); > + pd->asb_clk[i] = clk_get(dev, clk_name); > + if (IS_ERR(pd->asb_clk[i])) > + break; > + } > + > pd->oscclk = clk_get(dev, "oscclk"); > if (IS_ERR(pd->oscclk)) > goto no_clk; > -- Sylwester Nawrocki Samsung R&D Institute Poland