From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754773AbbCLOQm (ORCPT ); Thu, 12 Mar 2015 10:16:42 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:27062 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753902AbbCLOQj (ORCPT ); Thu, 12 Mar 2015 10:16:39 -0400 Message-ID: <55019FB7.1000806@oracle.com> Date: Thu, 12 Mar 2015 09:16:23 -0500 From: Dave Kleikamp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Scott Wood , trivial@kernel.org, linux-kernel@vger.kernel.org CC: jfs-discussion@lists.sourceforge.net Subject: Re: [Jfs-discussion] [PATCH 19/22] jfs: %pF is only for function pointers References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-19-git-send-email-scottwood@freescale.com> In-Reply-To: <1426130037-17956-19-git-send-email-scottwood@freescale.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2015 10:13 PM, Scott Wood wrote: > Use %pS for actual addresses, otherwise you'll get bad output > on arches like ppc64 where %pF expects a function descriptor. > > Signed-off-by: Scott Wood > Cc: jfs-discussion@lists.sourceforge.net Acked-by: Dave Kleikamp Do you intend to submit these as a set, or would you rather I push this one through the jfs subsystem? Thanks, Shaggy > --- > fs/jfs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/jfs/super.c b/fs/jfs/super.c > index 5d30c56..4cd9798 100644 > --- a/fs/jfs/super.c > +++ b/fs/jfs/super.c > @@ -102,7 +102,7 @@ void jfs_error(struct super_block *sb, const char *fmt, ...) > vaf.fmt = fmt; > vaf.va = &args; > > - pr_err("ERROR: (device %s): %pf: %pV\n", > + pr_err("ERROR: (device %s): %ps: %pV\n", > sb->s_id, __builtin_return_address(0), &vaf); > > va_end(args); >