From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754897AbbCLOcQ (ORCPT ); Thu, 12 Mar 2015 10:32:16 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:33500 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753908AbbCLOcN (ORCPT ); Thu, 12 Mar 2015 10:32:13 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: p.zabel@pengutronix.de X-SENDER-IP: 103.47.144.139 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5501A34A.6050105@rock-chips.com> Date: Thu, 12 Mar 2015 22:31:38 +0800 From: yakir User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Philipp Zabel CC: djkurtz@chromium.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, David Airlie , Russell King , Andy Yan , Greg Kroah-Hartman , Fabio Estevam , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, mmind00@googlemail.com, marcheu@chromium.org, mark.yao@rock-chips.com Subject: Re: [PATCH v4 02/15] drm: bridge/dw_hdmi: wrap irq control in fucntions References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425176927-1784-1-git-send-email-ykk@rock-chips.com> <1426155862.14455.19.camel@pengutronix.de> In-Reply-To: <1426155862.14455.19.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp, On 2015年03月12日 18:24, Philipp Zabel wrote: > Hi Yakir, > > Am Samstag, den 28.02.2015, 21:28 -0500 schrieb Yakir Yang: >> Wrap irq control in functions, and then we can call in >> dw_hdmi_bind/dw_hdmi_unbind/dw_hdmi_resume/dw_hdmi_suspend >> functions. >> >> Signed-off-by: Yakir Yang > [...] Sorry, I can not understand this comment. could you please talk more detail about this one. Thank you very much :) >> @@ -1702,17 +1722,8 @@ EXPORT_SYMBOL_GPL(dw_hdmi_unbind); >> int dw_hdmi_suspend(struct device *dev) >> { >> struct dw_hdmi *hdmi = dev_get_drvdata(dev); >> - u8 ih_mute; >> - >> - /* Disable all interrupts */ >> - hdmi_writeb(hdmi, ~0, HDMI_IH_MUTE_PHY_STAT0); >> - >> - /* Disable top level interrupt bits in HDMI block */ >> - ih_mute = hdmi_readb(hdmi, HDMI_IH_MUTE) | >> - HDMI_IH_MUTE_MUTE_WAKEUP_INTERRUPT | >> - HDMI_IH_MUTE_MUTE_ALL_INTERRUPT; >> >> - hdmi_writeb(hdmi, ih_mute, HDMI_IH_MUTE); >> + hdmi_mute_interrupts(hdmi); >> >> return 0; >> } >> @@ -1722,19 +1733,7 @@ int dw_hdmi_resume(struct device *dev) >> { >> struct dw_hdmi *hdmi = dev_get_drvdata(dev); >> >> - /* >> - * Configure registers related to HDMI interrupt >> - * generation before registering IRQ. >> - */ >> - hdmi_writeb(hdmi, HDMI_PHY_HPD, HDMI_PHY_POL0); >> - >> - /* Clear Hotplug interrupts */ >> - hdmi_writeb(hdmi, HDMI_IH_PHY_STAT0_HPD, HDMI_IH_PHY_STAT0); >> - >> - dw_hdmi_fb_registered(hdmi); >> - >> - /* Unmute interrupts */ >> - hdmi_writeb(hdmi, ~HDMI_IH_PHY_STAT0_HPD, HDMI_IH_MUTE_PHY_STAT0); >> + hdmi_unmute_interrupts(hdmi); >> >> return 0; >> } > Here you remove code added in the previous patch. > It would be better to just apply patch 2 first and then rebase patch 1 > on top of it. Thanks, I will reorder patch 1 & patch 2, in next vesion :) > regards > Philipp regards :) Yakir > > > >