From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754911AbbCLOck (ORCPT ); Thu, 12 Mar 2015 10:32:40 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:56443 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754183AbbCLOci (ORCPT ); Thu, 12 Mar 2015 10:32:38 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: p.zabel@pengutronix.de X-SENDER-IP: 103.47.144.139 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5501A365.2080109@rock-chips.com> Date: Thu, 12 Mar 2015 22:32:05 +0800 From: yakir User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Philipp Zabel CC: djkurtz@chromium.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, David Airlie , Russell King , Andy Yan , Greg Kroah-Hartman , Fabio Estevam , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, mmind00@googlemail.com, marcheu@chromium.org, mark.yao@rock-chips.com Subject: Re: [PATCH v4 03/15] drm: rockchip/dw_hdmi_rockchip: add resume/suspend support References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425177128-1844-1-git-send-email-ykk@rock-chips.com> <1426155872.14455.21.camel@pengutronix.de> In-Reply-To: <1426155872.14455.21.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp, On 2015年03月12日 18:24, Philipp Zabel wrote: > Am Samstag, den 28.02.2015, 21:32 -0500 schrieb Yakir Yang: >> Signed-off-by: Yakir Yang >> --- >> Changes in v4: None >> Changes in v3: >> - Setting the .pm member instead of suspend/resume >> >> Changes in v2: >> - Add suspend/resume support for dw_hdmi_rockchip driver >> >> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >> index d236faa..fc1d02e 100644 >> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >> @@ -323,11 +323,27 @@ static int dw_hdmi_rockchip_remove(struct platform_device *pdev) >> return 0; >> } >> >> +static int dw_hdmi_rockchip_suspend(struct device *dev) >> +{ >> + return dw_hdmi_suspend(dev); >> +} >> + >> +static int dw_hdmi_rockchip_resume(struct device *dev) >> +{ >> + return dw_hdmi_resume(dev); >> +} > You could just skip dw_hdmi_rockchip_suspend/resume and > set .suspend/.resume in dw_hdmi_rockchip_pm directly to > dw_hdmi_suspend/resume. > Okay, sounds good, I will adjust it in next version. Thanks :) >> +static const struct dev_pm_ops dw_hdmi_rockchip_pm = { >> + .resume = dw_hdmi_rockchip_resume, >> + .suspend = dw_hdmi_rockchip_suspend, >> +}; >> + >> static struct platform_driver dw_hdmi_rockchip_pltfm_driver = { >> .probe = dw_hdmi_rockchip_probe, >> .remove = dw_hdmi_rockchip_remove, >> .driver = { >> .name = "dwhdmi-rockchip", >> + .pm = &dw_hdmi_rockchip_pm, >> .of_match_table = dw_hdmi_rockchip_dt_ids, >> }, >> }; > regards > Philipp > regards :) Yakir > >