From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941AbbCLSQO (ORCPT ); Thu, 12 Mar 2015 14:16:14 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:34059 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbbCLSQL (ORCPT ); Thu, 12 Mar 2015 14:16:11 -0400 Message-ID: <5501D7E7.6040603@cogentembedded.com> Date: Thu, 12 Mar 2015 21:16:07 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: John Stultz , lkml CC: "David S. Miller" , Arnd Bergmann , linux-ide@vger.kernel.org Subject: Re: [PATCH] ide: pdc202xxx_new: Remove do_gettimeofday() usage for ktime_get References: <1426181032-2397-1-git-send-email-john.stultz@linaro.org> In-Reply-To: <1426181032-2397-1-git-send-email-john.stultz@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 03/12/2015 08:23 PM, John Stultz wrote: > As part of the y2038 cleanups, this patch removes the do_gettimeofday > usage replacing it with ktime_get. > Cc: "David S. Miller" > Cc: Arnd Bergmann > Cc: linux-ide@vger.kernel.org > Signed-off-by: John Stultz > --- > drivers/ide/pdc202xx_new.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > diff --git a/drivers/ide/pdc202xx_new.c b/drivers/ide/pdc202xx_new.c > index df73cbd..94bd05f 100644 > --- a/drivers/ide/pdc202xx_new.c > +++ b/drivers/ide/pdc202xx_new.c [...] > @@ -273,8 +274,7 @@ static long detect_pll_input_clock(unsigned long dma_base) > * Calculate the input clock in Hz > * (the clock counter is 30 bit wide and counts down) > */ > - usec_elapsed = (end_time.tv_sec - start_time.tv_sec) * 1000000 + > - (end_time.tv_usec - start_time.tv_usec); > + usec_elapsed = (long)ktime_to_ns(ktime_sub(end_time, start_time))/1000; Please add spaces around / to be consistent with this file's (and general kernel) coding style. > pll_input = ((start_count - end_count) & 0x3fffffff) / 10 * > (10000000 / usec_elapsed); > MBR, Sergei