From: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] dgnc: convert TRUE/FALSE #defines to 1/0
Date: Thu, 12 Mar 2015 21:18:37 +0200 [thread overview]
Message-ID: <5501E68D.6010802@gmail.com> (raw)
In-Reply-To: <20150312185915.GC10964@mwanda>
On 2015.03.12 20:59, Dan Carpenter wrote:
> On Thu, Mar 12, 2015 at 08:14:25PM +0200, Giedrius Statkevičius wrote:
>> TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it
>> would be better to just use 1/0 to avoid unnecessary extra files and
>> includes.
>>
>
> Use true/false. I don't care much about this personally but true/false
> is kernel style these days.
>
> regards,
> dan carpenter
>
After researching more this whole dgnc_Major_Serial_Registered and
dgnc_Major_TransparentPrint_Registered seem pretty pointless because
they only get set to true or false depending on if those boards are
initialised or not and we won't initialise them two or more times -
dgnc_init_one() is a probe method and it's never called anywhere else.
This seems like a way better solution - redundant stuff will be removed
from the struct and a unnecessary header will be removed (types.h is for
bools) :) I'll fix this up in v2 but now I'll wait for more comments on
other patches (if there will be any) for a bit.
--
Thanks,
Giedrius
next prev parent reply other threads:[~2015-03-12 19:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 18:14 [PATCH 1/6] dgnc: clean up digi.h Giedrius Statkevičius
2015-03-12 18:14 ` [PATCH 2/6] dgnc: get rid of dpacompat.h, move remaining stuff to digi.h Giedrius Statkevičius
2015-03-12 18:14 ` [PATCH 3/6] dgnc: convert TRUE/FALSE #defines to 1/0 Giedrius Statkevičius
2015-03-12 18:59 ` Dan Carpenter
2015-03-12 19:18 ` Giedrius Statkevičius [this message]
2015-03-12 18:14 ` [PATCH 4/6] dgnc: remove old 2.4-2.6 compat kernel defines Giedrius Statkevičius
2015-03-12 18:14 ` [PATCH 5/6] dgnc: remove unused stuff from dgnc_cls.h Giedrius Statkevičius
2015-03-12 18:14 ` [PATCH 6/6] dgnc: Clean up dgnc_sysfs.h Giedrius Statkevičius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5501E68D.6010802@gmail.com \
--to=giedrius.statkevicius@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox