From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754812AbbCMLa2 (ORCPT ); Fri, 13 Mar 2015 07:30:28 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:51665 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbbCMLaZ (ORCPT ); Fri, 13 Mar 2015 07:30:25 -0400 X-AuditID: cbfee691-f79b86d000004a5a-dd-5502ca4e0c6f Message-id: <5502CA4E.9060401@samsung.com> Date: Fri, 13 Mar 2015 20:30:22 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-version: 1.0 To: Doug Anderson , Jaehoon Chung , Seungwon Jeon , Ulf Hansson Cc: Alim Akhtar , Sonny Rao , Andrew Bresticker , Heiko Stuebner , Addy Ke , Alexandru Stan , javier.martinez@collabora.co.uk, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, chris@printf.net, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors References: <1426002490-2014-1-git-send-email-dianders@chromium.org> In-reply-to: <1426002490-2014-1-git-send-email-dianders@chromium.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsWyRsSkWNfvFFOowcSz6hYr3/9ltFj2/zuT xYN529gsGl5MYrWYcHk7o8XZZQfZLP4/es1qcfR3gcWNX22sFpseX2O1uLxrDpvFkf/9jBaf HvxntnhyZiajxYf7F5ktjq8NdxDwmN1wkcXj7/PrLB53ru1h89i8pN7jxquFTB5/Z+1n8ejb sorRY/u1ecwenzfJBXBGcdmkpOZklqUW6dslcGXcWZ5X8Ia/4vK9OawNjNd5uhg5OCQETCTO bhfsYuQEMsUkLtxbz9bFyMUhJLCUUWJm/yE2iISJxOsp31khEosYJdYtXgjlvGaUmHFuC1gV r4CWxNfDW9lBprIIqEos+8ADEmYT0JHY/u04E4gtKhAmMfHmY1aIckGJH5PvsYDYIgILGSWe 9YSCzGQWWMgscXDqR2aQhLBAqETLjw6w+UICLhKTV0M0cAq4Sly8spcRZBezgJ7E/YtaIGFm AXmJzWveMoPMkRBYyyGxZmcP2DIWAQGJb5MPsUB8LCux6QAzxGOSEgdX3GCZwCg2C8lJsxCm zkIydQEj8ypG0dSC5ILipPQiU73ixNzi0rx0veT83E2MwGg//e/ZxB2M9w9YH2IU4GBU4uHt rGIKFWJNLCuuzD3EaAp0xERmKdHkfGBKySuJNzQ2M7IwNTE1NjK3NFMS59WR/hksJJCeWJKa nZpakFoUX1Sak1p8iJGJg1OqgdHzqOiWHM/GuQs0/AtmSkR3TGiR0EpZmXioR8piru6pxb35 /sfzJL4k92x+3n3rtbFEzTsd2cmKF32v/5Z88zAvcILkMwseWdbI+M6HygeDutWj/i7hVn99 devflMJgs/eGcnZhBX/uSevMbt78P0Pm5hPZszsfO57IXls3715I406/B8trnymxFGckGmox FxUnAgChHDhL8QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsVy+t9jAV2/U0yhBjPXy1msfP+X0WLZ/+9M Fg/mbWOzaHgxidViwuXtjBZnlx1ks/j/6DWrxdHfBRY3frWxWmx6fI3V4vKuOWwWR/73M1p8 evCf2eLJmZmMFh/uX2S2OL423EHAY3bDRRaPv8+vs3jcubaHzWPzknqPG68WMnn8nbWfxaNv yypGj+3X5jF7fN4kF8AZ1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeY m2qr5OIToOuWmQP0hZJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYx487y vII3/BWX781hbWC8ztPFyMkhIWAi8XrKd1YIW0ziwr31bF2MXBxCAosYJdYtXsgK4bxmlJhx bgsbSBWvgJbE18Nb2bsYOThYBFQlln0AG8QmoCOx/dtxJhBbVCBMYuLNx6wQ5YISPybfYwGx RQQWMko86wkFmckssJBZ4uDUj8wgCWGBUImWHx1g84UEXCQmr4Zo4BRwlbh4ZS8jyC5mAT2J +xe1QMLMAvISm9e8ZZ7AKDALyYpZCFWzkFQtYGRexSiaWpBcUJyUnmuoV5yYW1yal66XnJ+7 iRGcTJ5J7WBc2WBxiFGAg1GJh7ejiilUiDWxrLgy9xCjBAezkghv7GqgEG9KYmVValF+fFFp TmrxIUZToP8nMkuJJucDE11eSbyhsYmZkaWRuaGFkbG5kjivkn1biJBAemJJanZqakFqEUwf EwenVAPjuptSVjsuJGhcuXpmudSnvtfNrhcXLF5jlN5WdOrUwdCv2YLXrqx/u1Qt+dZuT6ss fouUQnsO/7LA/xO9c93Ld7+aYPV6NVM5f4wj+6KddlNDOG/bMe7nE5nSVmV3ealGt8CWKmaD gtlfnjzacuz9/DUuh4+3vjGOsE06qn9QbVetdg7LF2lNJZbijERDLeai4kQAL3NuhzwDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Doug. On 03/11/2015 12:48 AM, Doug Anderson wrote: > The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but > nothing in the interrupt handler actually handles them and ACKs them. > That means that if we ever get an HLE error we'll just keep getting > interrupts and we'll wedge things. > > We really don't expect HLE errors but if we ever get them we shouldn't > silently ignore them. > > Note that I have seen HLE errors while constantly ejecting and > inserting cards (ejecting while inserting, etc). Right, It is occurred when card inserting/ejecting.(This case is the case of removable card.) Did you test with eMMC? We needs to consider how control HLE error. But I think this patch can't solve all of HLE problem. Best Regards, Jaehoon Chung > > Signed-off-by: Doug Anderson > --- > Note that this works together with the patch I sent up yesterday (the > CMD 11 timer). I would have sent the two together except that I had > local printouts (and ACKing of HLE) and didn't realize that this was > also required for a full solution. > > drivers/mmc/host/dw_mmc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 47dfd0e..294edc9c 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -44,11 +44,11 @@ > /* Common flag combinations */ > #define DW_MCI_DATA_ERROR_FLAGS (SDMMC_INT_DRTO | SDMMC_INT_DCRC | \ > SDMMC_INT_HTO | SDMMC_INT_SBE | \ > - SDMMC_INT_EBE) > + SDMMC_INT_EBE | SDMMC_INT_HLE) > #define DW_MCI_CMD_ERROR_FLAGS (SDMMC_INT_RTO | SDMMC_INT_RCRC | \ > - SDMMC_INT_RESP_ERR) > + SDMMC_INT_RESP_ERR | SDMMC_INT_HLE) > #define DW_MCI_ERROR_FLAGS (DW_MCI_DATA_ERROR_FLAGS | \ > - DW_MCI_CMD_ERROR_FLAGS | SDMMC_INT_HLE) > + DW_MCI_CMD_ERROR_FLAGS) > #define DW_MCI_SEND_STATUS 1 > #define DW_MCI_RECV_STATUS 2 > #define DW_MCI_DMA_THRESHOLD 16 >