From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753050AbbCMLtl (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Mar 2015 07:49:41 -0400
Received: from arroyo.ext.ti.com ([192.94.94.40]:52455 "EHLO arroyo.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751267AbbCMLtj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Mar 2015 07:49:39 -0400
Message-ID: <5502CE9E.1020705@ti.com>
Date: Fri, 13 Mar 2015 13:48:46 +0200
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Arnd Bergmann <arnd@arndb.de>, Marek Belisko <marek@goldelico.com>
CC: <bcousson@baylibre.com>, <tony@atomide.com>, <eballetbo@gmail.com>,
        <javier@dowhile0.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <jarkko.nikula@bitmer.com>,
        <hns@goldelico.com>
Subject: Re: [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property
References: <1426194899-14037-1-git-send-email-marek@goldelico.com> <1426194899-14037-3-git-send-email-marek@goldelico.com> <38159868.RLZZTyUOlK@wuerfel>
In-Reply-To: <38159868.RLZZTyUOlK@wuerfel>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/13/2015 01:05 PM, Arnd Bergmann wrote:
> On Thursday 12 March 2015 22:14:59 Marek Belisko wrote:
>> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt
>> index 1ab6bc8..656165f 100644
>> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt
>> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt
>> @@ -4,7 +4,6 @@ Required properties:
>>  - compatible: "ti,omap-twl4030"
>>  - ti,model: Name of the sound card (for example "omap3beagle")
>>  - ti,mcbsp: phandle for the McBSP node
>> -- ti,codec: phandle for the twl4030 audio node
> 
> As this was a required property, are you sure that no other operating system
> uses it?
> 
> Even if not, you should probably change it to be an optional property, so
> that the existing dtbs do not become noncompliant after the change.

After I sent my Ack, I also started to think about the same thing. It is
better to change it to optional.

-- 
Péter