From: Alexei Starovoitov <ast@plumgrid.com>
To: He Kuang <hekuang@huawei.com>, Ingo Molnar <mingo@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Jiri Olsa <jolsa@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
"David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-api@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, wangnan0@huawei.com
Subject: Re: [PATCH v6 tip 3/8] tracing: allow BPF programs to call bpf_ktime_get_ns()
Date: Fri, 13 Mar 2015 09:38:37 -0700 [thread overview]
Message-ID: <5503128D.70908@plumgrid.com> (raw)
In-Reply-To: <5502C8EB.9070307@huawei.com>
On 3/13/15 4:24 AM, He Kuang wrote:
> Hi, Alexei
>
> I've followed up your bpf version. In bpf filter, sometimes we need to
> get 'pid' and some other context informations to decide whether to
> filter or not.
>
> For example, to trace a vfs read procedure, we can insert bpf program to
> '__vfs_read(struct file *file, char __user *buf ...)', mark some of
> 'buf' addresses and only trace the read procedure of these 'buf's. But
> this parameter is a userspace pointer, the value is meaningless to other
> processes, so we should also record 'pid' to make sense.
>
> To a function like __vfs_read, 'pid' can't be extracted from function
> parameters directly. What's your opinion on this issue?
yes. it's the next thing on todo list after this set of patches.
There are several ways to let programs see 'pid'. We'll debate about
the best approach hopefully soon :)
next prev parent reply other threads:[~2015-03-13 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 4:18 [PATCH v6 tip 0/8] tracing: attach eBPF programs to kprobes Alexei Starovoitov
2015-03-11 4:18 ` [PATCH v6 tip 1/8] bpf: make internal bpf API independent of CONFIG_BPF_SYSCALL ifdefs Alexei Starovoitov
2015-03-11 4:18 ` [PATCH v6 tip 2/8] tracing: attach BPF programs to kprobes Alexei Starovoitov
2015-03-12 15:15 ` Peter Zijlstra
2015-03-12 16:18 ` Alexei Starovoitov
2015-03-12 16:23 ` Steven Rostedt
2015-03-12 16:43 ` Alexei Starovoitov
2015-03-12 16:47 ` Steven Rostedt
2015-03-11 4:18 ` [PATCH v6 tip 3/8] tracing: allow BPF programs to call bpf_ktime_get_ns() Alexei Starovoitov
2015-03-13 11:24 ` He Kuang
2015-03-13 16:38 ` Alexei Starovoitov [this message]
2015-03-11 4:18 ` [PATCH v6 tip 4/8] tracing: allow BPF programs to call bpf_trace_printk() Alexei Starovoitov
2015-03-11 4:18 ` [PATCH v6 tip 5/8] samples: bpf: simple non-portable kprobe filter example Alexei Starovoitov
2015-03-11 4:18 ` [PATCH v6 tip 6/8] samples: bpf: counting example for kfree_skb and write syscall Alexei Starovoitov
2015-03-11 4:18 ` [PATCH v6 tip 7/8] samples: bpf: IO latency analysis (iosnoop/heatmap) Alexei Starovoitov
2015-03-11 4:18 ` [PATCH v6 tip 8/8] samples: bpf: kmem_alloc/free tracker Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5503128D.70908@plumgrid.com \
--to=ast@plumgrid.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox