* Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399
2017-11-29 18:47 [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399 Brian Norris
@ 2017-11-29 20:52 ` Doug Anderson
2017-12-04 10:05 ` Heiko Stuebner
2017-12-04 13:22 ` Laurent Pinchart
2 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2017-11-29 20:52 UTC (permalink / raw)
To: Brian Norris
Cc: Heiko Stübner, Archit Taneja, Andrzej Hajda,
Laurent Pinchart, David Airlie, Yannick Fertre, Philippe Cornu,
Benjamin Gaignard, Vincent Abriou, dri-devel, LKML, Sean Paul,
Nickey Yang, Lin Huang, open list:ARM/Rockchip SoC...,
Matthias Kaehlcke, Rob Herring, Mark Rutland, hoegsberg, Chris,
xbl
Hi,
On Wed, Nov 29, 2017 at 10:47 AM, Brian Norris <briannorris@chromium.org> wrote:
> From: Nickey Yang <nickey.yang@rock-chips.com>
>
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
>
> v4:
> * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> * separate from the rest of the series, since this is mostly
> independent of the driver refactoring
>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
This seems sane to me according to my current understanding and
reading of the bindings.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399
2017-11-29 18:47 [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399 Brian Norris
2017-11-29 20:52 ` Doug Anderson
@ 2017-12-04 10:05 ` Heiko Stuebner
2017-12-04 13:22 ` Laurent Pinchart
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2017-12-04 10:05 UTC (permalink / raw)
To: Brian Norris
Cc: Archit Taneja, Andrzej Hajda, Laurent Pinchart, David Airlie,
Yannick Fertre, Philippe Cornu, Benjamin Gaignard, Vincent Abriou,
dri-devel, linux-kernel, Sean Paul, Nickey Yang, hl,
linux-rockchip, mka, Doug Anderson, robh+dt, mark.rutland,
hoegsberg, zyw, xbl
Am Mittwoch, 29. November 2017, 10:47:55 CET schrieb Brian Norris:
> From: Nickey Yang <nickey.yang@rock-chips.com>
>
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
>
> v4:
> * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> * separate from the rest of the series, since this is mostly
> independent of the driver refactoring
>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
applied for 4.16 with Doug's Review
Thanks
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399
2017-11-29 18:47 [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399 Brian Norris
2017-11-29 20:52 ` Doug Anderson
2017-12-04 10:05 ` Heiko Stuebner
@ 2017-12-04 13:22 ` Laurent Pinchart
2017-12-04 13:46 ` Heiko Stuebner
2 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2017-12-04 13:22 UTC (permalink / raw)
To: Brian Norris
Cc: heiko, Archit Taneja, Andrzej Hajda, David Airlie, Yannick Fertre,
Philippe Cornu, Benjamin Gaignard, Vincent Abriou, dri-devel,
linux-kernel, Sean Paul, Nickey Yang, hl, linux-rockchip, mka,
Doug Anderson, robh+dt, mark.rutland, hoegsberg, zyw, xbl
Hi Nickey,
Thank you for the patch.
On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> From: Nickey Yang <nickey.yang@rock-chips.com>
>
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
>
> v4:
> * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> * separate from the rest of the series, since this is mostly
> independent of the driver refactoring
>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d340b58ab184..c6dae25a3f23
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,7 +1652,11 @@
> status = "disabled";
>
> ports {
> - mipi_in: port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mipi_in: port@0 {
> + reg = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399
2017-12-04 13:22 ` Laurent Pinchart
@ 2017-12-04 13:46 ` Heiko Stuebner
2017-12-04 16:36 ` Laurent Pinchart
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2017-12-04 13:46 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Brian Norris, Archit Taneja, Andrzej Hajda, David Airlie,
Yannick Fertre, Philippe Cornu, Benjamin Gaignard, Vincent Abriou,
dri-devel, linux-kernel, Sean Paul, Nickey Yang, hl,
linux-rockchip, mka, Doug Anderson, robh+dt, mark.rutland,
hoegsberg, zyw, xbl
Hi Laurent,
Am Montag, 4. Dezember 2017, 15:22:07 CET schrieb Laurent Pinchart:
> On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> > From: Nickey Yang <nickey.yang@rock-chips.com>
> >
> > We might include additional ports in derivative device trees, so the
> > 'port' node should have an address, and the parent 'ports' node needs
> > /#{addres,size}-cells.
> >
> > v4:
> > * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> > * separate from the rest of the series, since this is mostly
> > independent of the driver refactoring
> >
> > Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
As I hadn't pushed that one yet, I've amended it with your Review-tag :-)
Thanks
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399
2017-12-04 13:46 ` Heiko Stuebner
@ 2017-12-04 16:36 ` Laurent Pinchart
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2017-12-04 16:36 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Brian Norris, Archit Taneja, Andrzej Hajda, David Airlie,
Yannick Fertre, Philippe Cornu, Benjamin Gaignard, Vincent Abriou,
dri-devel, linux-kernel, Sean Paul, Nickey Yang, hl,
linux-rockchip, mka, Doug Anderson, robh+dt, mark.rutland,
hoegsberg, zyw, xbl
Hi Heiko,
On Monday, 4 December 2017 15:46:32 EET Heiko Stuebner wrote:
> Am Montag, 4. Dezember 2017, 15:22:07 CET schrieb Laurent Pinchart:
> > On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> > > From: Nickey Yang <nickey.yang@rock-chips.com>
> > >
> > > We might include additional ports in derivative device trees, so the
> > > 'port' node should have an address, and the parent 'ports' node needs
> > > /#{addres,size}-cells.
> > >
> > > v4:
> > > * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> > > * separate from the rest of the series, since this is mostly
> > >
> > > independent of the driver refactoring
> > >
> > > Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> > > Signed-off-by: Brian Norris <briannorris@chromium.org>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> As I hadn't pushed that one yet, I've amended it with your Review-tag :-)
Thank you :-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread