From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030215AbbCMSl1 (ORCPT ); Fri, 13 Mar 2015 14:41:27 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:42212 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753592AbbCMSlZ (ORCPT ); Fri, 13 Mar 2015 14:41:25 -0400 Message-ID: <55032F51.5090203@cogentembedded.com> Date: Fri, 13 Mar 2015 21:41:21 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Ameen Ali , grundler@parisc-linux.org CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 9/9] tulip_core.c : out-of-bounds check. References: <1426256152-5522-1-git-send-email-ameenali023@gmail.com> In-Reply-To: <1426256152-5522-1-git-send-email-ameenali023@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 03/13/2015 05:15 PM, Ameen Ali wrote: > Array index 'j' is used before limits check. > Suggest put limit check before index use. > Signed-off-by : > --- > drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c > index 3b42556..ed41559 100644 > --- a/drivers/net/ethernet/dec/tulip/tulip_core.c > +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c > @@ -589,7 +589,7 @@ static void tulip_tx_timeout(struct net_device *dev) > (unsigned int)tp->rx_ring[i].buffer1, > (unsigned int)tp->rx_ring[i].buffer2, > buf[0], buf[1], buf[2]); > - for (j = 0; buf[j] != 0xee && j < 1600; j++) > + for (j = 0; ((j < 1600) && buf[j] != 0xee); j++) No need for extra parens, either around < or around &&. WBR, Sergei