From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbbCMVct (ORCPT ); Fri, 13 Mar 2015 17:32:49 -0400 Received: from lists.s-osg.org ([54.187.51.154]:43107 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbbCMVcr (ORCPT ); Fri, 13 Mar 2015 17:32:47 -0400 Message-ID: <5503577C.9050002@osg.samsung.com> Date: Fri, 13 Mar 2015 15:32:44 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman CC: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, mmarek@suse.cz, linux-api@vger.kernel.org Subject: Re: [PATCH v4 4/9] selftests: Add install target References: <1426046765-19289-1-git-send-email-mpe@ellerman.id.au> <1426046765-19289-4-git-send-email-mpe@ellerman.id.au> <55031C78.4040609@osg.samsung.com> In-Reply-To: <55031C78.4040609@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2015 11:20 AM, Shuah Khan wrote: > On 03/10/2015 10:06 PM, Michael Ellerman wrote: >> This adds make install support to selftests. The basic usage is: >> >> $ cd tools/testing/selftests >> $ make install >> >> That installs into tools/testing/selftests/install, which can then be >> copied where ever necessary. >> >> The install destination is also configurable using eg: >> >> $ INSTALL_PATH=/mnt/selftests make install >> >> The implementation uses two targets in the child makefiles. The first >> "install" is expected to install all files into $(INSTALL_PATH). >> >> The second, "emit_tests", is expected to emit the test instructions (ie. >> bash script) on stdout. Separating this from install means the child >> makefiles need no knowledge of the location of the test script. >> >> Signed-off-by: Michael Ellerman > > Thanks for doing the work. This patch will be applied to next and will > be queued for 4.1 > ok. linux-kselftest next has both shared logic and install patches now. As I mentioned in my reply to shared logic patch, I had to drop the changes to timers Makefile to add shared logic, hence timers progs don't get installed at the moment. Could you please review to make sure, it looks right. As I said in the other email, if lib.mk could provide a way to run additional programs that require arguments in addition to RUN_TESTS. In the case of timers, there is one test that requires arguments. In some cases, e.g: memory hotplug, override works well since it is just one executable. In this case, there is a mix of executables that don't need any special handling and some that need it. You are welcome to add shared logic and install to timers if you would like. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978