From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751556AbbCOAkM (ORCPT <rfc822;w@1wt.eu>);
	Sat, 14 Mar 2015 20:40:12 -0400
Received: from h1446028.stratoserver.net ([85.214.92.142]:36636 "EHLO
	mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750850AbbCOAkI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 14 Mar 2015 20:40:08 -0400
Message-ID: <5504D4B9.2010901@ahsoftware.de>
Date: Sun, 15 Mar 2015 01:39:21 +0100
From: Alexander Holler <holler@ahsoftware.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Al Viro <viro@ZenIV.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>
CC: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [git pull] gadgetfs fixes
References: <20150313164228.GQ29656@ZenIV.linux.org.uk>
In-Reply-To: <20150313164228.GQ29656@ZenIV.linux.org.uk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 13.03.2015 um 17:42 schrieb Al Viro:
> 	Assorted fixes around AIO on gadgetfs: leaks, use-after-free,
> troubles caused by ->f_op flipping.  Please, pull from
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git gadget
> 
> Shortlog:
> Al Viro (8):
>       new helper: dup_iter()
>       move iov_iter.c from mm/ to lib/
>       gadget/function/f_fs.c: close leaks
>       gadget/function/f_fs.c: use put iov_iter into io_data
>       gadget/function/f_fs.c: switch to ->{read,write}_iter()

>       gadgetfs: use-after-free in ->aio_read()

If that patch ends up in the stable kernels (as it is marked as such),
it needs a
	value = -ENOMEM
before that added "goto fail;", otherwise the return value is unitialized.

Alexander Holler