From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753525AbbCPKL5 (ORCPT ); Mon, 16 Mar 2015 06:11:57 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:57493 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600AbbCPKL4 convert rfc822-to-8bit (ORCPT ); Mon, 16 Mar 2015 06:11:56 -0400 Message-ID: <5506AC65.4030703@ahsoftware.de> Date: Mon, 16 Mar 2015 11:11:49 +0100 From: Alexander Holler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Al Viro CC: Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [git pull] gadgetfs fixes References: <20150313164228.GQ29656@ZenIV.linux.org.uk> <5504D4B9.2010901@ahsoftware.de> <20150315013948.GU29656@ZenIV.linux.org.uk> <55052828.7090701@ahsoftware.de> <20150315081733.GV29656@ZenIV.linux.org.uk> <5505435D.5030103@ahsoftware.de> In-Reply-To: <5505435D.5030103@ahsoftware.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.03.2015 um 09:31 schrieb Alexander Holler: > Am 15.03.2015 um 09:17 schrieb Al Viro: >> On Sun, Mar 15, 2015 at 07:35:20AM +0100, Alexander Holler wrote: >> >>>> Umm... If I'm not misparsing what you said, you are talking about the >>> >>> Glücklicherweise nicht. Vielleicht sollten wir es zur Abwechslung mal >>> mit meiner bevorzugten Sprache versuchen. >> >> Good. I'll probably abstain from trying to mangle it, though. >> >> Another question, if you don't mind - does that series (i.e. what's >> currently >> in Linus' tree) fix the module refcount issues you'd been seeing? I >> agree >> with your analysis of likely cause (->f_op reassignments with different >> ->owner before and after) and these patches should have eliminated >> that, but >> confirmation would be nice... > > I haven't tried to apply the whole series to the 3.19.1 which I'm > currently using. As mentioned before, something (a single patch I've > tried before) didn't apply cleanly which means I need to have a deeper > look at the stuff. E.g. I've just learned (through another problem), > that (my version of) glibc still doesn't use the aio-syscalls the kernel > provides (and instead uses pread/pwrite). > > I will look if I find the time today. Also it's already merged, looks good. Please just don't forget to add that value = -ENOMEM; if commit f01d35a1 goes down the road without the following patches. Thanks, Alexander Holler