From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753409AbbCPKtL (ORCPT ); Mon, 16 Mar 2015 06:49:11 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:40809 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbbCPKtI (ORCPT ); Mon, 16 Mar 2015 06:49:08 -0400 Message-ID: <5506B516.9070206@ti.com> Date: Mon, 16 Mar 2015 12:48:54 +0200 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Nicholas Mc Guire , Tony Lindgren CC: Samuel Ortiz , Lee Jones , , Subject: Re: [PATCH] mfd: twl6040: match wait_for_completion_timeout return type References: <1426493822-10331-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1426493822-10331-1-git-send-email-hofrat@osadl.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/16/2015 10:17 AM, Nicholas Mc Guire wrote: > Return type of wait_for_completion_timeout is unsigned long not int. As > time_left is exclusively used for wait_for_completion_timeout here its > type is simply changed to unsigned long. Acked-by: Peter Ujfalusi > Signed-off-by: Nicholas Mc Guire > --- > > Patch was compile tested with x86_64_defconfig + CONFIG_TWL6040_CORE=y > > Patch is against 4.0-rc3 (localversion-next is -next-20150316) > > drivers/mfd/twl6040.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c > index f71ee3d..d6f9761 100644 > --- a/drivers/mfd/twl6040.c > +++ b/drivers/mfd/twl6040.c > @@ -259,7 +259,7 @@ static irqreturn_t twl6040_thint_handler(int irq, void *data) > > static int twl6040_power_up_automatic(struct twl6040 *twl6040) > { > - int time_left; > + unsigned long time_left; > > gpio_set_value(twl6040->audpwron, 1); > > -- Péter