From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753940AbbCPLFu (ORCPT ); Mon, 16 Mar 2015 07:05:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60440 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbbCPLFr (ORCPT ); Mon, 16 Mar 2015 07:05:47 -0400 Message-ID: <5506B908.1060007@suse.de> Date: Mon, 16 Mar 2015 12:05:44 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Javier Martinez Canillas CC: Kukjin Kim , Olof Johansson , Doug Anderson , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] ARM: dts: Define stdout-path property for Spring board References: <1426501710-24177-1-git-send-email-javier.martinez@collabora.co.uk> <1426501710-24177-4-git-send-email-javier.martinez@collabora.co.uk> In-Reply-To: <1426501710-24177-4-git-send-email-javier.martinez@collabora.co.uk> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 16.03.2015 um 11:28 schrieb Javier Martinez Canillas: > The kernel can use as the default console a serial port if is defined "The kernel can use a serial port as the default console if it's defined ..." > as stdout device in the Device Tree. > > This allows a board to be booted without the need of having a console > parameter in the kernel command line. > > Currently the Spring DTS has bootargs in the /chosen node and this is > kept since users that don't have a serial console on this board might > be using it to have the boot log shown in the display. This will have > more precedence than the stdout-path but it's fine since is only used "since it's" > when CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is enabled. > > Signed-off-by: Javier Martinez Canillas > --- > arch/arm/boot/dts/exynos5250-spring.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts > index f02775487cd4..b9ec763a5602 100644 > --- a/arch/arm/boot/dts/exynos5250-spring.dts > +++ b/arch/arm/boot/dts/exynos5250-spring.dts > @@ -25,6 +25,7 @@ > > chosen { > bootargs = "console=tty1"; > + stdout-path = "serial3:115200n8"; Is this a guess or did you verify that against some schematics? > }; > > gpio-keys { Assuming that bootargs still work, Reviewed-by: Andreas Färber I do wonder why this mechanism could not point to the same location as bootargs? ("dp-controller"?) The device does not even have screws for opening it, so accessing the serial port is highly theoretical. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)