From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754085AbbCPLjS (ORCPT ); Mon, 16 Mar 2015 07:39:18 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:21528 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750862AbbCPLjP (ORCPT ); Mon, 16 Mar 2015 07:39:15 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Mon, 16 Mar 2015 11:39:14 +0000 Message-ID: <5506C0E0.80901@imgtec.com> Date: Mon, 16 Mar 2015 11:39:12 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Alex Dowad , CC: open list: METAG ARCHITECTURE , ; Illegal-Object: Syntax error in CC: address found on vger.kernel.org: CC: ; ^-missing semicolon to end mail group, extraneous tokens in mailbox, missing end of mailbox Subject: Re: [PATCH 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg' References: <1426270496-26362-1-git-send-email-alexinbeijing@gmail.com> <1426270496-26362-6-git-send-email-alexinbeijing@gmail.com> In-Reply-To: <1426270496-26362-6-git-send-email-alexinbeijing@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ben3OA2SpMpkJexHFWSbOLnAixp1xXlfH" X-Originating-IP: [192.168.154.110] X-ESG-ENCRYPT-TAG: da4c5968 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ben3OA2SpMpkJexHFWSbOLnAixp1xXlfH Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 13/03/15 18:14, Alex Dowad wrote: > The 'arg' argument to copy_thread() is only ever used when forking a ne= w > kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consi= stency > with do_fork() and other arch-specific implementations of copy_thread()= ). >=20 > Signed-off-by: Alex Dowad > --- > arch/metag/kernel/process.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c > index 483dff9..dcb4609 100644 > --- a/arch/metag/kernel/process.c > +++ b/arch/metag/kernel/process.c > @@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs) > show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs); > } > =20 > +/* > + * Copy architecture-specific thread state > + */ > int copy_thread(unsigned long clone_flags, unsigned long usp, > - unsigned long arg, struct task_struct *tsk) > + unsigned long kthread_arg, struct task_struct *tsk) > { > struct pt_regs *childregs =3D task_pt_regs(tsk); > void *kernel_context =3D ((void *) childregs + > @@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsign= ed long usp, > childregs->ctx.AX[0].U0 =3D (unsigned long) kernel_context; > /* Set D1Ar1=3Darg and D1RtP=3Dusp (fn) */ Please update this comment too (ctx.DX[3].U1 stores the D1Ar1 register). Other than that: Acked-by: James Hogan I'll assume you plan to get all these patches merged together rather than via individual arch trees unless you say otherwise. Cheers James > childregs->ctx.DX[4].U1 =3D usp; > - childregs->ctx.DX[3].U1 =3D arg; > + childregs->ctx.DX[3].U1 =3D kthread_arg; > tsk->thread.int_depth =3D 2; > return 0; > } > + > /* > * Get a pointer to where the new child's register block should have > * been pushed. >=20 --ben3OA2SpMpkJexHFWSbOLnAixp1xXlfH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVBsDhAAoJEGwLaZPeOHZ6FkIQALLlAjW2+15k7/9qzx6ENjWU gbF3S9yu/0tkC5OFxY46F3n/la0k7JENK/PciyvJYB/f87eExvQsya3KrdWg/F73 QM6qwPvrBO7nOb725vcQ+R0iPJxBrsyF3Q8EkvTJdEE/XTACiJ2mUrmBaikd45O6 OCVamKewbsBK8WXcjq7u5aytchD7M6G/cvqPQyWahG6o9jzxMWFuoxdHgi19jH44 7+sfycV4H9w9Lxe9Ue/Ij1gZ8PGj//NXGKICFaPKbujQrwXm+T8HKUHqT1wudFo+ JfwCZVUkNjNAMkyy5UcwjXW4qaKGKkRfFnRquXABb/EgeDuQtT2knocXnU7UGVed ZArD1sGxK2V6RXrwpQsEKSVtfrxhCVhvsK81oUWY9yjOGm6fIB9954dldt7IYojo LC+aGqZaN3txrU6T4W0GJ5yuX3hrPcY5GjAhuskrLc38MeKtrNovAsJRKc24JSov bWsYK57KE//mhkU9ZAI28bqQLFB57fvsBAB85Py/k94mS/VaIO9kVuh579DkpiFh fezeFwJDT8jeDNF2EvbtzeNIhOSLCjxzfkNkJycVDldhTKFGeiHYf+e+vwuqTpnr GUJnSUhbX0/DFkiGJn/4AfUY5AgHWIyC7T9TbaF1zjWyxmQ4PdzRnWXNcdpRCULx QO2JzEenBH8IXA+yb4jA =swex -----END PGP SIGNATURE----- --ben3OA2SpMpkJexHFWSbOLnAixp1xXlfH--