From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754581AbbCPOJN (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Mar 2015 10:09:13 -0400
Received: from smtp.citrix.com ([66.165.176.89]:48430 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754448AbbCPOJL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Mar 2015 10:09:11 -0400
X-IronPort-AV: E=Sophos;i="5.11,409,1422921600"; 
   d="scan'208";a="243741931"
Message-ID: <5506E3FA.7040304@citrix.com>
Date: Mon, 16 Mar 2015 14:08:58 +0000
From: David Vrabel <david.vrabel@citrix.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: Peter Zijlstra <peterz@infradead.org>, <Waiman.Long@hp.com>
CC: <raghavendra.kt@linux.vnet.ibm.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <hpa@zytor.com>,
        <boris.ostrovsky@oracle.com>, <linux-arch@vger.kernel.org>,
        <x86@kernel.org>, <mingo@redhat.com>, <doug.hatch@hp.com>,
        <xen-devel@lists.xenproject.org>, <paulmck@linux.vnet.ibm.com>,
        <riel@redhat.com>, <scott.norton@hp.com>, <paolo.bonzini@gmail.com>,
        <tglx@linutronix.de>, <virtualization@lists.linux-foundation.org>,
        <oleg@redhat.com>, <luto@amacapital.net>, <david.vrabel@citrix.com>,
        <torvalds@linux-foundation.org>
Subject: Re: [Xen-devel] [PATCH 0/9] qspinlock stuff -v15
References: <20150316131613.720617163@infradead.org>
In-Reply-To: <20150316131613.720617163@infradead.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16/03/15 13:16, Peter Zijlstra wrote:
> Hi Waiman,
> 
> As promised; here is the paravirt stuff I did during the trip to BOS last week.
> 
> All the !paravirt patches are more or less the same as before (the only real
> change is the copyright lines in the first patch).
> 
> The paravirt stuff is 'simple' and KVM only -- the Xen code was a little more
> convoluted and I've no real way to test that but it should be stright fwd to
> make work.
> 
> I ran this using the virtme tool (thanks Andy) on my laptop with a 4x
> overcommit on vcpus (16 vcpus as compared to the 4 my laptop actually has) and
> it both booted and survived a hackbench run (perf bench sched messaging -g 20
> -l 5000).
> 
> So while the paravirt code isn't the most optimal code ever conceived it does work.
> 
> Also, the paravirt patching includes replacing the call with "movb $0, %arg1"
> for the native case, which should greatly reduce the cost of having
> CONFIG_PARAVIRT_SPINLOCKS enabled on actual hardware.
> 
> I feel that if someone were to do a Xen patch we can go ahead and merge this
> stuff (finally!).

I can look at this.  It looks pretty straight-forward.

> These patches do not implement the paravirt spinlock debug stats currently
> implemented (separately) by KVM and Xen, but that should not be too hard to do
> on top and in the 'generic' code -- no reason to duplicate all that.

I think this is fine.

David