From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755983AbbCPOcE (ORCPT ); Mon, 16 Mar 2015 10:32:04 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:39915 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754944AbbCPOcA (ORCPT ); Mon, 16 Mar 2015 10:32:00 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Mon, 16 Mar 2015 14:31:58 +0000 Message-ID: <5506E95D.70204@imgtec.com> Date: Mon, 16 Mar 2015 14:31:57 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Alex Dowad CC: , Subject: Re: [PATCHv2 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg' References: <5506C0E0.80901@imgtec.com> <1426511630-19370-1-git-send-email-alexinbeijing@gmail.com> In-Reply-To: <1426511630-19370-1-git-send-email-alexinbeijing@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IfKIkVokPpaB2r5ihf7aOxNNJh07GglIr" X-Originating-IP: [192.168.154.110] X-ESG-ENCRYPT-TAG: da4c5968 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IfKIkVokPpaB2r5ihf7aOxNNJh07GglIr Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Alex, On 16/03/15 13:13, Alex Dowad wrote: > The 'arg' argument to copy_thread() is only ever used when forking a ne= w > kernel thread. Hence, rename it to 'kthread_arg' for clarity. >=20 > Signed-off-by: Alex Dowad > --- >=20 > James Hogan, >=20 > Thanks for reviewing this patch. The comment has been updated as you su= ggested. >=20 > You said: "I'll assume you plan to get all these patches merged togethe= r rather than > via individual arch trees..." The truth is that I am as green as green = can be and have > no idea how I plan to get these patches merged. I was just reading the = Linux source and > saw what looked like an opportunity to make the code a tiny bit easier = to read. If you > have any suggestions on how to proceed, please let me know. I guess there are 3 main paths: 1) Ask individual arch maintainers to apply the patches if possible, since it doesn't have dependencies on other patches you're submitting. 2) Gather acks from maintainers for the remaining patches and ask Andrew Morton or another relevant maintainer to apply them (Andrew often picks up misc patches like this I believe). 3) Or gather acks for remaining patches and send a pull request to Linus yourself during the next merge window. Btw, the whitespace seems to be corrupted here, so the patch won't apply:= > - /* Set D1Ar1=3Darg and D1RtP=3Dusp (fn) */ ^^^ currently this is indented with tabs not spaces > + /* Set D1Ar1=3Dkthread_arg and D1RtP=3Dusp (fn) */ ^^^ and this has a space before a tab Cheers James > childregs->ctx.DX[4].U1 =3D usp; > - childregs->ctx.DX[3].U1 =3D arg; > + childregs->ctx.DX[3].U1 =3D kthread_arg; > tsk->thread.int_depth =3D 2; > return 0; > } > + > /* > * Get a pointer to where the new child's register block should have > * been pushed. >=20 --IfKIkVokPpaB2r5ihf7aOxNNJh07GglIr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVBuldAAoJEGwLaZPeOHZ6m8AQALjll0uP1Wue8LeyAhnqoaP3 765509EESUcQ4SUOUzQFqOx/L085qU4Ix6El+QcirHOaihKBkp80xjMuWVCmUMFZ n4MDf2NwhsIPkAr0ERJLYkZSDVMGbLsKeF33RoAzePLdg9VVLJ180yUDj7MhJBcx 2DKe3UXrNwIoeUi/wF0zVeCleH6KTVUKFnjpebmSvci2YxCSVdjDK9w2hQpgaQyb 3ZFiAhupfWVaqGlNEUST+oYHaw6RNMD6uVLQUd44hpqhfHpKEXXaTuO59A4+IVQN MDK/Vt6khmNulTLV9dgv1pDNfcC3S7MWNfRKrOgjMRXjsf8WqxwyWcrewLC/kv8Z CJRE4wW0JGPXQys7RJsQ3S6BM23btfZsvWijRO2NPRrYFyXd9RoTdWAjqLt15VgB /xDebyC58W7Mvba2SZevWukNJBHZ766LErm31dCnDFpDt6r6bh2ry1CjcCU8k8nt f58rxOPkUxfc0MI3XxXMaduvxFPKfbWPkoBTCDTS2tVGB+kuRjidf/yUl7kgj5LC V96r1PIni5JAxPkeU/POXEe8CAAKIBJ3xw0J4ZtEXC6E46rQXcVAbWBu5NnvKCt/ mgZntDaj70Y5BFsZsb+ELBu5dsHqfF6cnFd9D1tsiSwJ67xn5wcbw/sYEyakLgkK /hCYs5rKM4/zwTzD/VeC =Ecnm -----END PGP SIGNATURE----- --IfKIkVokPpaB2r5ihf7aOxNNJh07GglIr--