From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933862AbbCPOwc (ORCPT ); Mon, 16 Mar 2015 10:52:32 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:49796 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933042AbbCPOw2 (ORCPT ); Mon, 16 Mar 2015 10:52:28 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Mon, 16 Mar 2015 14:52:26 +0000 Message-ID: <5506EE29.50802@imgtec.com> Date: Mon, 16 Mar 2015 14:52:25 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Alex Dowad CC: , Subject: Re: [PATCHv3 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg' References: <5506E95D.70204@imgtec.com> <1426516727-20692-1-git-send-email-alexinbeijing@gmail.com> In-Reply-To: <1426516727-20692-1-git-send-email-alexinbeijing@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5tvFQ4gkupMfrgm96EVFLNfui8CxURQbV" X-Originating-IP: [192.168.154.110] X-ESG-ENCRYPT-TAG: b93fcccb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5tvFQ4gkupMfrgm96EVFLNfui8CxURQbV Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 16/03/15 14:38, Alex Dowad wrote: > The 'arg' argument to copy_thread() is only ever used when forking a ne= w > kernel thread. Hence, rename it to 'kthread_arg' for clarity. >=20 > Signed-off-by: Alex Dowad > --- >=20 > Fixed problem with whitespace, sending again. AD >=20 > arch/metag/kernel/process.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c > index 483dff9..dcb4609 100644 > --- a/arch/metag/kernel/process.c > +++ b/arch/metag/kernel/process.c > @@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs) > show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs); > } > =20 > +/* > + * Copy architecture-specific thread state > + */ > int copy_thread(unsigned long clone_flags, unsigned long usp, > - unsigned long arg, struct task_struct *tsk) > + unsigned long kthread_arg, struct task_struct *tsk) > { > struct pt_regs *childregs =3D task_pt_regs(tsk); > void *kernel_context =3D ((void *) childregs + > @@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsign= ed long usp, > childregs->ctx.AX[0].U0 =3D (unsigned long) kernel_context; > - /* Set D1Ar1=3Darg and D1RtP=3Dusp (fn) */ > + /* Set D1Ar1=3Dkthread_arg and D1RtP=3Dusp (fn) */ FYI this still has a space before the tab, and isn't indented to the same level as the surrounding code, but I'll just fix that up when I apply it. Thanks James > childregs->ctx.DX[4].U1 =3D usp; > - childregs->ctx.DX[3].U1 =3D arg; > + childregs->ctx.DX[3].U1 =3D kthread_arg; > tsk->thread.int_depth =3D 2; > return 0; > } > + > /* > * Get a pointer to where the new child's register block should have > * been pushed. >=20 --5tvFQ4gkupMfrgm96EVFLNfui8CxURQbV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVBu4pAAoJEGwLaZPeOHZ6hTgQAIY2zYWSfZK41IslHhRs1+Nh MMq/Oxom9gxurQb361CNujvsbYE3usNaYFd/xLMF3zXHhTDKHX0+E9ZMuZ7TrgJ/ UpnOYawEPv+TEhKUClHUKXflPeh20XcUwZ9RbL0ZvyMiRYOEPP1BV19ykEazqHbK ttma9KWBVvAtYrKJIzE8FJVsvyXEqx9jRR7+KpDVD+vrk1k41rxRB7VRwli8li23 JubOR191PDjDnV+mEvIX9xNR1ISXLTs/LPzt6ey7pWig/Wh/01F6Qy5KD7tAq5RI u8t8gEqE/GivPigzFuO2BOyS4T69xIbw1qBAk2birh/ncJR7RdfvWeRWlwFEf4Lj Tag7tAiE7+qDJp1/FCDCmm6cQ7+FWfjCXl9hUhzmzkeGKmMMqUF0xM3S/3KLOYUX f1hGpxqIFuvXAUEnngbq6/TDeZMi4S/TjAoTmIchvJtZhYqU9P8zOf5wqux8wM8G ZS6A11JyuvzZP5ueLK9owkeQwCdQohKkmC6St2KyDpvR/DwHJVBYBQxWTQ328WJZ ++VOuwqn3dvjMBRSj/ZJkAb/DeukYbdDKqBhal88kcE0OqmahNtuOhlh7WqQRL4x C5sF1uIX0oQ0U74PSbg+zs2PKTze/r6U502bihCX5CB3El1aP5io7Qlr80WBEaMe QcdDol+MI25+CJXyD/uH =IRFQ -----END PGP SIGNATURE----- --5tvFQ4gkupMfrgm96EVFLNfui8CxURQbV--