From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964972AbbCPUtK (ORCPT ); Mon, 16 Mar 2015 16:49:10 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:27929 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755580AbbCPUtG (ORCPT ); Mon, 16 Mar 2015 16:49:06 -0400 X-AuditID: cbfec7f5-b7fc86d0000066b7-f8-55074129cd08 Message-id: <550741BD.9080109@partner.samsung.com> Date: Mon, 16 Mar 2015 23:49:01 +0300 From: Stefan Strogin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Joonsoo Kim , Andrew Morton , Marek Szyprowski , Michal Nazarewicz , aneesh.kumar@linux.vnet.ibm.com, Laurent Pinchart , Dmitry Safonov , Pintu Kumar , Weijie Yang , Laura Abbott , SeongJae Park , Hui Zhu , Minchan Kim , Dyasly Sergey , Vyacheslav Tyrtov , Aleksei Mateosian , gregory.0xf0@gmail.com, sasha.levin@oracle.com, gioh.kim@lge.com, pavel@ucw.cz, stefan.strogin@gmail.com, Steven Rostedt , Ingo Molnar Subject: Re: [PATCH v4 1/5] mm: cma: add trace events to debug physically-contiguous memory allocations References: In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SXUhTYRzGe8/XezZSjkvlNEhrIVKQmRm8RkYJxSGEAhtYXtTUqQOnsqmo XWQp4haZU8s1TQZq5VpqM/ArZC6/RbBmRpPJrDTUTNT8QNPlaRd29+P//Hiemz+Ni0YJMa1I y5Sr0mSpEkpIDO/0j584dhFKQ+d0YjRVUwZRdZOZQt/mawi03DBNoZn7vwF6UtlMooYHBRRq 1egh0ujqILJ3VFNo0uwm0eseJ0TG/kISPV9dhOij1Ygh51AvhUrW30PUVezCUHmVGK0NVuOo tmcCR+NtjzBk/+mG6LF+A6LB5hESNRcIL4g5e8lDjGs3OCFX2OWAXFXxU5KzmDQUZ1kug5x2 YQzjBvRbBOeytRBc4585jFuadhBc9693GLfY9YniSt6aAPfy1TrkViwB13xuCs8lylMV2XLV yfO3hSlFyxqYMe6f0zBjwvPBdx8tENAsE87au0egh/3Z0ckmSguEtIipB6x7s/dfIGKWALug ucOzFxPGNt17g/NMMEGsq8VK8UztFvWNVgItoGk/JpadsAs8ug+7UT5J8Oy7q3QWPAN8P84M U6z7xxbJBwcYBbtoXcI9wwbATqx9AXwgYJLY0q0ZyJfiTDBbUaHkzzgTyLaYF/BSsCvvbRj2 LMN/lhHgJuAnz0rIUMcnK8NC1DKlOistOSQhXWkBni9YbQP1fWdtgKGBZL9XbCAlFZGybHWu 0gZYGpf4eq1JoFTklSjLzZOr0m+pslLlahvAaIE4Hxh7mfkzkY3elpiHov4bcYcjFEVktKoo 2i43R9LTmC78q/zzJX+613F1dmAgauwoDI7RtO2Lai3L39FLpzY7pHSm0xjRTjtds4Ir8bqp gKDO9IPD20dqXY6hPH3S4qDA23q3Med6kC10Im67bvjF6OUPxi3vukOnJw0rwkAfCaFOkZ06 jqvUsr9kXXoj4wIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oops... forgot to cc tracing maintainers. Sorry! On 16/03/15 19:06, Stefan Strogin wrote: > Add trace events for cma_alloc() and cma_release(). > > Signed-off-by: Stefan Strogin > --- > include/trace/events/cma.h | 57 ++++++++++++++++++++++++++++++++++++++++++++++ > mm/cma.c | 5 ++++ > 2 files changed, 62 insertions(+) > create mode 100644 include/trace/events/cma.h > > diff --git a/include/trace/events/cma.h b/include/trace/events/cma.h > new file mode 100644 > index 0000000..d88881b > --- /dev/null > +++ b/include/trace/events/cma.h > @@ -0,0 +1,57 @@ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM cma > + > +#if !defined(_TRACE_CMA_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_CMA_H > + > +#include > +#include > + > +TRACE_EVENT(cma_alloc, > + > + TP_PROTO(struct cma *cma, struct page *page, int count), > + > + TP_ARGS(cma, page, count), > + > + TP_STRUCT__entry( > + __field(struct page *, page) > + __field(unsigned long, count) > + ), > + > + TP_fast_assign( > + __entry->page = page; > + __entry->count = count; > + ), > + > + TP_printk("page=%p pfn=%lu count=%lu", > + __entry->page, > + __entry->page ? page_to_pfn(__entry->page) : 0, > + __entry->count) > +); > + > +TRACE_EVENT(cma_release, > + > + TP_PROTO(struct cma *cma, unsigned long pfn, int count), > + > + TP_ARGS(cma, pfn, count), > + > + TP_STRUCT__entry( > + __field(unsigned long, pfn) > + __field(unsigned long, count) > + ), > + > + TP_fast_assign( > + __entry->pfn = pfn; > + __entry->count = count; > + ), > + > + TP_printk("pfn=%lu page=%p count=%lu", > + __entry->pfn, > + pfn_to_page(__entry->pfn), > + __entry->count) > +); > + > +#endif /* _TRACE_CMA_H */ > + > +/* This part must be outside protection */ > +#include > diff --git a/mm/cma.c b/mm/cma.c > index 47203fa..63dfc0e 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -23,6 +23,7 @@ > # define DEBUG > #endif > #endif > +#define CREATE_TRACE_POINTS > > #include > #include > @@ -34,6 +35,7 @@ > #include > #include > #include > +#include > > #include "cma.h" > > @@ -414,6 +416,8 @@ struct page *cma_alloc(struct cma *cma, unsigned int count, unsigned int align) > start = bitmap_no + mask + 1; > } > > + trace_cma_alloc(cma, page, count); > + > pr_debug("%s(): returned %p\n", __func__, page); > return page; > } > @@ -446,6 +450,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count) > > free_contig_range(pfn, count); > cma_clear_bitmap(cma, pfn, count); > + trace_cma_release(cma, pfn, count); > > return true; > } >