From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934200AbbCPVpq (ORCPT ); Mon, 16 Mar 2015 17:45:46 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:36569 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933980AbbCPVpo (ORCPT ); Mon, 16 Mar 2015 17:45:44 -0400 Message-ID: <55074F04.2070700@gmail.com> Date: Mon, 16 Mar 2015 22:45:40 +0100 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Dan Carpenter CC: gregkh@linuxfoundation.org, joe@perches.com, devel@driverdev.osuosl.org, mdcasey@chabloom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) References: <1426059960-11587-1-git-send-email-mateusz.kulikowski@gmail.com> <1426204401-20414-2-git-send-email-mateusz.kulikowski@gmail.com> <20150316084405.GG10964@mwanda> In-Reply-To: <20150316084405.GG10964@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.03.2015 09:44, Dan Carpenter wrote: > On Fri, Mar 13, 2015 at 12:53:16AM +0100, Mateusz Kulikowski wrote: >> - RT_TRACE(COMP_RECV, "HwRateToMRate90(): Non supported" >> - "Rate [%x], bIsHT = %d!!!\n", rate, bIsHT); >> - break; >> + RT_TRACE(COMP_RECV, >> + "HwRateToMRate90(): Non supportedRate [%x], bIsHT = %d!!!\n", > > There should be a space character between "supported" and "Rate". You > can fix it in a later patch though, it's minor. And really no one cares > about RT_TRACE() output. Thanks for the hint - there is a lot of other typos in messages - I will probably fix them later on; As for RT_TRACE - my plan is to replace the whole "proprietary logging system" with dynamic debug (i.e. netdev_dbg() or pr_debug()), but again - this is bigger patch and I'll prepare it after this series is merged. Regards, Mateusz