From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933746AbbCPV6H (ORCPT ); Mon, 16 Mar 2015 17:58:07 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:34310 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753799AbbCPV6E (ORCPT ); Mon, 16 Mar 2015 17:58:04 -0400 Message-ID: <550751E7.30503@gmail.com> Date: Mon, 16 Mar 2015 22:57:59 +0100 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Joe Perches CC: gregkh@linuxfoundation.org, mdcasey@chabloom.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) References: <1426204401-20414-1-git-send-email-mateusz.kulikowski@gmail.com> <1426204401-20414-2-git-send-email-mateusz.kulikowski@gmail.com> <1426206426.9314.4.camel@perches.com> In-Reply-To: <1426206426.9314.4.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.03.2015 01:27, Joe Perches wrote: > > Another thing you might consider is to change these > embedded function names in another patch to use > "%s: ", __func__ > > RT_TRACE(COMP_ERR, > "%s: "unknown hardware version\n", > __func__) > > There's a cocci script for that. > http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names This tool (coccinelle) looks great - I will once take look at it and do swap like suggested; It probably can be used to cleanup other parts of this driver as well - if I knew about it earlier it would save me a lot of repetitive work. Regards, Mateusz