From: Scott Branden <sbranden@broadcom.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org,
"Dmitry Torokhov" <dtor@google.com>,
"Anatol Pomazao" <anatol@google.com>,
"Ray Jui" <rjui@broadcom.com>,
"Corneliu Doban" <cdoban@broadcom.com>,
"Jonathan Richardson" <jonathar@broadcom.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Kevin Cernekee" <cernekee@gmail.com>
Subject: Re: [PATCH 2/3] Documentation: devicetree: add binding doc for Broadcom NAND controller
Date: Mon, 16 Mar 2015 16:40:13 -0700 [thread overview]
Message-ID: <550769DD.2020208@broadcom.com> (raw)
In-Reply-To: <20150316233706.GL32500@ld-irv-0074>
On 15-03-16 04:37 PM, Brian Norris wrote:
> On Mon, Mar 16, 2015 at 04:07:51PM -0700, Scott Branden wrote:
>> On 15-03-06 05:18 PM, Brian Norris wrote:
>>> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>>> ---
>>> .../devicetree/bindings/mtd/brcmstb_nand.txt | 109 +++++++++++++++++++++
>>> 1 file changed, 109 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/mtd/brcmstb_nand.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/brcmstb_nand.txt b/Documentation/devicetree/bindings/mtd/brcmstb_nand.txt
>>> new file mode 100644
>>> index 000000000000..933d44943cbb
>>> --- /dev/null
>>
>> Could you change the binding document with the vendor prefix to
>> match all the other drivers we have been submitting? ie.
>> "brcm,brcmnand.txt"
>
> $ find Documentation/devicetree/ -name 'broadcom*'
> Documentation/devicetree/bindings/net/broadcom-systemport.txt
> Documentation/devicetree/bindings/net/broadcom-bcm87xx.txt
> Documentation/devicetree/bindings/net/broadcom-mdio-unimac.txt
> Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
> Documentation/devicetree/bindings/net/broadcom-sf2.txt
>
> $ find Documentation/devicetree/ -name 'brcm[^,]*'
> Documentation/devicetree/bindings/arm/brcm-brcmstb.txt
>
> $ find Documentation/devicetree/ -name 'brcm,*'
> Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
> Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
> Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt
> Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt
> Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
> Documentation/devicetree/bindings/i2c/brcm,bcm2835-i2c.txt
> Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt
> Documentation/devicetree/bindings/rng/brcm,bcm2835.txt
> Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt
> Documentation/devicetree/bindings/pinctrl/brcm,bcm11351-pinctrl.txt
> Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
> Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm11351-cpu-method
> Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhci.txt
> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>
> $ find Documentation/devicetree/bindings -name '*.txt' | grep -v ','| wc -l
> 1227
> $ find Documentation/devicetree/bindings -name '*.txt' | grep ','| wc -l
> 352
>
> So, what's the standard? Company prefix? Long name? Commas? Hyphens?
The problem with devicetree binding is there is no standard for much of
anything. Some others use the vendor prefix for all their binding
documentation. We can try to do the same?
>
> Brian
>
next prev parent reply other threads:[~2015-03-16 23:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 1:18 [PATCH 0/3] mtd: nand: add Broadcom NAND controller support Brian Norris
2015-03-07 1:18 ` [PATCH 1/3] mtd: nand: add common DT init code Brian Norris
2015-03-07 1:18 ` [PATCH 2/3] Documentation: devicetree: add binding doc for Broadcom NAND controller Brian Norris
2015-03-16 18:49 ` Florian Fainelli
2015-03-16 23:07 ` Scott Branden
2015-03-16 23:37 ` Brian Norris
2015-03-16 23:40 ` Scott Branden [this message]
2015-03-16 23:46 ` Brian Norris
2015-03-16 23:52 ` Scott Branden
2015-03-07 1:18 ` [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB " Brian Norris
2015-03-07 12:39 ` Paul Bolle
2015-03-09 17:30 ` Brian Norris
2015-03-07 13:21 ` Rafał Miłecki
2015-03-09 17:31 ` Brian Norris
2015-03-07 17:39 ` Rafał Miłecki
2015-03-07 21:48 ` Rafał Miłecki
2015-03-08 0:44 ` Rafał Miłecki
2015-03-09 17:49 ` Brian Norris
2015-03-09 17:57 ` Ray Jui
2015-03-07 22:15 ` Rafał Miłecki
2015-03-16 18:55 ` Florian Fainelli
2015-03-19 1:49 ` Brian Norris
2015-03-16 19:58 ` Florian Fainelli
2015-03-08 0:01 ` [PATCH 0/3] mtd: nand: add Broadcom NAND controller support Rafał Miłecki
2015-03-08 0:57 ` Brian Norris
2015-03-08 10:22 ` Rafał Miłecki
2015-03-09 18:04 ` Brian Norris
2015-03-08 11:18 ` Rafał Miłecki
2015-03-09 17:59 ` Brian Norris
[not found] ` <CALj_zD5rW3Se27Rh0pL6QTMNGOrrmrvAVLvW3BCuF8RujYQE=g@mail.gmail.com>
2015-03-16 23:44 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550769DD.2020208@broadcom.com \
--to=sbranden@broadcom.com \
--cc=anatol@google.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cdoban@broadcom.com \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dtor@google.com \
--cc=f.fainelli@gmail.com \
--cc=jonathar@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox