* [PATCH] phy: qcom-ufs: Catch devm_phy_create failure in ufs_qcom_phy_generic_probe
@ 2015-03-03 1:05 Axel Lin
2015-03-17 0:47 ` Axel Lin
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2015-03-03 1:05 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Yaniv Gardi, Dov Levenglick, linux-kernel@vger.kernel.org
Current code does NULL test against return value of ufs_qcom_phy_generic_probe.
However, in the case of devm_phy_create() failure, ufs_qcom_phy_generic_probe
does not return NULL. Fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/phy-qcom-ufs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 44ee983..d95effe 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -101,6 +101,7 @@ struct phy *ufs_qcom_phy_generic_probe(struct platform_device *pdev,
if (IS_ERR(generic_phy)) {
err = PTR_ERR(generic_phy);
dev_err(dev, "%s: failed to create phy %d\n", __func__, err);
+ generic_phy = NULL;
goto out;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] phy: qcom-ufs: Catch devm_phy_create failure in ufs_qcom_phy_generic_probe
2015-03-03 1:05 [PATCH] phy: qcom-ufs: Catch devm_phy_create failure in ufs_qcom_phy_generic_probe Axel Lin
@ 2015-03-17 0:47 ` Axel Lin
2015-03-17 9:09 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2015-03-17 0:47 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Yaniv Gardi, Dov Levenglick, linux-kernel@vger.kernel.org
2015-03-03 9:05 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> Current code does NULL test against return value of ufs_qcom_phy_generic_probe.
> However, in the case of devm_phy_create() failure, ufs_qcom_phy_generic_probe
> does not return NULL. Fix it.
Hi Kishon,
Seems this patch is missed.
Should I resend it?
Thanks,
Axel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: qcom-ufs: Catch devm_phy_create failure in ufs_qcom_phy_generic_probe
2015-03-17 0:47 ` Axel Lin
@ 2015-03-17 9:09 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2015-03-17 9:09 UTC (permalink / raw)
To: Axel Lin; +Cc: Yaniv Gardi, Dov Levenglick, linux-kernel@vger.kernel.org
On Tuesday 17 March 2015 06:17 AM, Axel Lin wrote:
> 2015-03-03 9:05 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
>> Current code does NULL test against return value of ufs_qcom_phy_generic_probe.
>> However, in the case of devm_phy_create() failure, ufs_qcom_phy_generic_probe
>> does not return NULL. Fix it.
> Hi Kishon,
> Seems this patch is missed.
> Should I resend it?
not necessary, I have the patch with me.
Thanks
Kishon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-17 9:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-03 1:05 [PATCH] phy: qcom-ufs: Catch devm_phy_create failure in ufs_qcom_phy_generic_probe Axel Lin
2015-03-17 0:47 ` Axel Lin
2015-03-17 9:09 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox