* [PATCH] phy: omap-usb2: Fix missing clk_prepare call when using old dt name
@ 2015-03-11 1:41 Axel Lin
2015-03-17 10:21 ` Roger Quadros
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-03-11 1:41 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Roger Quadros, Felipe Balbi, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Current code does not call clk_prepare(phy->optclk) when using the old
usb_otg_ss_refclk960m name. Fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/phy-omap-usb2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c
index 6f4aef3..dcdd850 100644
--- a/drivers/phy/phy-omap-usb2.c
+++ b/drivers/phy/phy-omap-usb2.c
@@ -296,10 +296,11 @@ static int omap_usb2_probe(struct platform_device *pdev)
dev_warn(&pdev->dev,
"found usb_otg_ss_refclk960m, please fix DTS\n");
}
- } else {
- clk_prepare(phy->optclk);
}
+ if (!IS_ERR(phy->optclk))
+ clk_prepare(phy->optclk);
+
usb_add_phy_dev(&phy->phy);
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] phy: omap-usb2: Fix missing clk_prepare call when using old dt name
2015-03-11 1:41 [PATCH] phy: omap-usb2: Fix missing clk_prepare call when using old dt name Axel Lin
@ 2015-03-17 10:21 ` Roger Quadros
0 siblings, 0 replies; 2+ messages in thread
From: Roger Quadros @ 2015-03-17 10:21 UTC (permalink / raw)
To: Axel Lin, Kishon Vijay Abraham I
Cc: Felipe Balbi, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, 3.9+
+stable, v3.16+
On 11/03/15 03:41, Axel Lin wrote:
> Current code does not call clk_prepare(phy->optclk) when using the old
> usb_otg_ss_refclk960m name. Fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
> ---
> drivers/phy/phy-omap-usb2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c
> index 6f4aef3..dcdd850 100644
> --- a/drivers/phy/phy-omap-usb2.c
> +++ b/drivers/phy/phy-omap-usb2.c
> @@ -296,10 +296,11 @@ static int omap_usb2_probe(struct platform_device *pdev)
> dev_warn(&pdev->dev,
> "found usb_otg_ss_refclk960m, please fix DTS\n");
> }
> - } else {
> - clk_prepare(phy->optclk);
> }
>
> + if (!IS_ERR(phy->optclk))
> + clk_prepare(phy->optclk);
> +
> usb_add_phy_dev(&phy->phy);
>
> return 0;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-17 10:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-11 1:41 [PATCH] phy: omap-usb2: Fix missing clk_prepare call when using old dt name Axel Lin
2015-03-17 10:21 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox