* [vfio:next 19/21] drivers/vfio/virqfd.c:19:1: sparse: symbol 'virqfd_lock' was not declared. Should it be static?
@ 2015-03-16 23:43 kbuild test robot
2015-03-16 23:43 ` [PATCH vfio] vfio: virqfd_lock can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-03-16 23:43 UTC (permalink / raw)
To: Antonios Motakis
Cc: kbuild-all, Alex Williamson, Baptiste Reynal, kvm, linux-kernel
tree: git://github.com/awilliam/linux-vfio.git next
head: 2f51bf4be99386f49841b6365a85a5cabc148565
commit: 42ac9bd18d4fc28c36c7927847f0f6e90ecd7710 [19/21] vfio: initialize the virqfd workqueue in VFIO generic code
reproduce:
# apt-get install sparse
git checkout 42ac9bd18d4fc28c36c7927847f0f6e90ecd7710
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/vfio/virqfd.c:19:1: sparse: symbol 'virqfd_lock' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH vfio] vfio: virqfd_lock can be static
2015-03-16 23:43 [vfio:next 19/21] drivers/vfio/virqfd.c:19:1: sparse: symbol 'virqfd_lock' was not declared. Should it be static? kbuild test robot
@ 2015-03-16 23:43 ` kbuild test robot
2015-03-17 10:49 ` Eric Auger
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-03-16 23:43 UTC (permalink / raw)
To: Antonios Motakis
Cc: kbuild-all, Alex Williamson, Baptiste Reynal, kvm, linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
virqfd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/virqfd.c b/drivers/vfio/virqfd.c
index 5967899..3d19aaf 100644
--- a/drivers/vfio/virqfd.c
+++ b/drivers/vfio/virqfd.c
@@ -16,7 +16,7 @@
#include <linux/slab.h>
static struct workqueue_struct *vfio_irqfd_cleanup_wq;
-DEFINE_SPINLOCK(virqfd_lock);
+static DEFINE_SPINLOCK(virqfd_lock);
int __init vfio_virqfd_init(void)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH vfio] vfio: virqfd_lock can be static
2015-03-16 23:43 ` [PATCH vfio] vfio: virqfd_lock can be static kbuild test robot
@ 2015-03-17 10:49 ` Eric Auger
0 siblings, 0 replies; 3+ messages in thread
From: Eric Auger @ 2015-03-17 10:49 UTC (permalink / raw)
To: kbuild test robot, Antonios Motakis
Cc: kbuild-all, Alex Williamson, Baptiste Reynal, kvm, linux-kernel
Reviewed-by: Eric Auger <eric.auger@linaro.org>
On 03/17/2015 12:43 AM, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> virqfd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/virqfd.c b/drivers/vfio/virqfd.c
> index 5967899..3d19aaf 100644
> --- a/drivers/vfio/virqfd.c
> +++ b/drivers/vfio/virqfd.c
> @@ -16,7 +16,7 @@
> #include <linux/slab.h>
>
> static struct workqueue_struct *vfio_irqfd_cleanup_wq;
> -DEFINE_SPINLOCK(virqfd_lock);
> +static DEFINE_SPINLOCK(virqfd_lock);
>
> int __init vfio_virqfd_init(void)
> {
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-17 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-16 23:43 [vfio:next 19/21] drivers/vfio/virqfd.c:19:1: sparse: symbol 'virqfd_lock' was not declared. Should it be static? kbuild test robot
2015-03-16 23:43 ` [PATCH vfio] vfio: virqfd_lock can be static kbuild test robot
2015-03-17 10:49 ` Eric Auger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox