From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932261AbbCQOfK (ORCPT ); Tue, 17 Mar 2015 10:35:10 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:35669 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753586AbbCQOfF (ORCPT ); Tue, 17 Mar 2015 10:35:05 -0400 Message-ID: <55083B94.6020309@gmail.com> Date: Tue, 17 Mar 2015 16:35:00 +0200 From: =?UTF-8?B?R2llZHJpdXMgU3RhdGtldmnEjWl1cw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: lidza.louina@gmail.com, markh@compro.net CC: gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] dgnc: remove unused dgnc_ioctl_name() command References: <1426254995-28359-1-git-send-email-giedrius.statkevicius@gmail.com> In-Reply-To: <1426254995-28359-1-git-send-email-giedrius.statkevicius@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg, you probably missed these :) Could you look at these when you have some time? On 2015.03.13 15:56, Giedrius Statkevičius wrote: > dgnc_ioctl_name() is never used anywhere so remove it > > Signed-off-by: Giedrius Statkevičius > --- > v2: Forgot to include this patch in the first version. Without this some > of the other patches in this set will fail. > > drivers/staging/dgnc/dgnc_utils.c | 52 --------------------------------------- > drivers/staging/dgnc/dgnc_utils.h | 1 - > 2 files changed, 53 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_utils.c b/drivers/staging/dgnc/dgnc_utils.c > index 80b5133..f76de82 100644 > --- a/drivers/staging/dgnc/dgnc_utils.c > +++ b/drivers/staging/dgnc/dgnc_utils.c > @@ -16,55 +16,3 @@ int dgnc_ms_sleep(ulong ms) > schedule_timeout((ms * HZ) / 1000); > return signal_pending(current); > } > - > -/* > - * dgnc_ioctl_name() : Returns a text version of each ioctl value. > - */ > -char *dgnc_ioctl_name(int cmd) > -{ > - switch (cmd) { > - > - case TCGETA: return "TCGETA"; > - case TCGETS: return "TCGETS"; > - case TCSETA: return "TCSETA"; > - case TCSETS: return "TCSETS"; > - case TCSETAW: return "TCSETAW"; > - case TCSETSW: return "TCSETSW"; > - case TCSETAF: return "TCSETAF"; > - case TCSETSF: return "TCSETSF"; > - case TCSBRK: return "TCSBRK"; > - case TCXONC: return "TCXONC"; > - case TCFLSH: return "TCFLSH"; > - case TIOCGSID: return "TIOCGSID"; > - > - case TIOCGETD: return "TIOCGETD"; > - case TIOCSETD: return "TIOCSETD"; > - case TIOCGWINSZ: return "TIOCGWINSZ"; > - case TIOCSWINSZ: return "TIOCSWINSZ"; > - > - case TIOCMGET: return "TIOCMGET"; > - case TIOCMSET: return "TIOCMSET"; > - case TIOCMBIS: return "TIOCMBIS"; > - case TIOCMBIC: return "TIOCMBIC"; > - > - /* from digi.h */ > - case DIGI_SETA: return "DIGI_SETA"; > - case DIGI_SETAW: return "DIGI_SETAW"; > - case DIGI_SETAF: return "DIGI_SETAF"; > - case DIGI_SETFLOW: return "DIGI_SETFLOW"; > - case DIGI_SETAFLOW: return "DIGI_SETAFLOW"; > - case DIGI_GETFLOW: return "DIGI_GETFLOW"; > - case DIGI_GETAFLOW: return "DIGI_GETAFLOW"; > - case DIGI_GETA: return "DIGI_GETA"; > - case DIGI_GEDELAY: return "DIGI_GEDELAY"; > - case DIGI_SEDELAY: return "DIGI_SEDELAY"; > - case DIGI_GETCUSTOMBAUD: return "DIGI_GETCUSTOMBAUD"; > - case DIGI_SETCUSTOMBAUD: return "DIGI_SETCUSTOMBAUD"; > - case TIOCMODG: return "TIOCMODG"; > - case TIOCMODS: return "TIOCMODS"; > - case TIOCSDTR: return "TIOCSDTR"; > - case TIOCCDTR: return "TIOCCDTR"; > - > - default: return "unknown"; > - } > -} > diff --git a/drivers/staging/dgnc/dgnc_utils.h b/drivers/staging/dgnc/dgnc_utils.h > index cebf601..1164c3a 100644 > --- a/drivers/staging/dgnc/dgnc_utils.h > +++ b/drivers/staging/dgnc/dgnc_utils.h > @@ -2,6 +2,5 @@ > #define __DGNC_UTILS_H > > int dgnc_ms_sleep(ulong ms); > -char *dgnc_ioctl_name(int cmd); > > #endif > -- Thanks, Giedrius