From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932303AbbCQPTx (ORCPT ); Tue, 17 Mar 2015 11:19:53 -0400 Received: from mail.kernel.org ([198.145.29.136]:60559 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754308AbbCQPTs (ORCPT ); Tue, 17 Mar 2015 11:19:48 -0400 Message-ID: <5508460A.7030608@kernel.org> Date: Wed, 18 Mar 2015 00:19:38 +0900 From: Kukjin Kim User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.16 MIME-Version: 1.0 To: Sylwester Nawrocki CC: Beata Michalska , kgene@kernel.org, tomasz.figa@gmail.com, mturquette@linaro.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, cw00.choi@samsung.com, kyungmin.park@samsung.com, sw0312.kim@samsung.com Subject: Re: [PATCH 2/2] ARM: dts: exynos3250: Add assigned clock parents to CMU node References: <1425302250-13446-1-git-send-email-b.michalska@samsung.com> <1425302250-13446-3-git-send-email-b.michalska@samsung.com> <5508078C.6010902@samsung.com> In-Reply-To: <5508078C.6010902@samsung.com> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/17/15 19:53, Sylwester Nawrocki wrote: > On 02/03/15 14:17, Beata Michalska wrote: >> Use assigned-clocks/assigned-clock-parents properties for >> CMU clock controller DT node to secure proper clock setup: >> switching the two muxes to root oscillator clock is not only >> required for proper powering down the ISP power domain, >> but it also reduces the risk of accessing the ISP CMU >> registers while the ISP power domain remains turned off >> (i.e. through the common clock framework by clk_summary) >> >> Signed-off-by: Beata Michalska >> Acked-by: Kyungmin Park > > Acked-by: Sylwester Nawrocki > > Kukjin, please merge this patch for v4.1. I merged the exynos3250 > CMU ISP driver patch and we will have regression if $subject patch > is not applied, i.e. reading /sys/kernel/debug/clk/clk_summary > would cause system hang on exynos3250. > OK, applied. Thanks, Kukjin >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 277b48b..6d6118e 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -172,6 +172,10 @@ >> compatible = "samsung,exynos3250-cmu"; >> reg = <0x10030000 0x20000>; >> #clock-cells = <1>; >> + assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>, >> + <&cmu CLK_MOUT_ACLK_266_SUB>; >> + assigned-clock-parents = <&cmu CLK_FIN_PLL>, >> + <&cmu CLK_FIN_PLL>; >> }; >> >> cmu_dmc: clock-controller@105C0000 { >> > > Thanks, > Sylwester